Found by the mutation review of #43 (review). Reported by Data, filed by Riker. This is a follow-up. It is not a regression from #43.
What happens
search prints (more results available) when Slack reports more pages, but it gives the user no way to read them. The command always requests page 1.
Slack.searchMessages already accepts a page parameter. Nothing in the CLI passes it. Data proved this by mutation: changing the facade to always send page 1 survives the whole test suite, because no test and no command ever asks for another page.
Why this is worth fixing
The user is told more results exist and is then given no command to reach them. Raising --limit is not an answer, because Slack caps count at 100 (see the sibling issue on --limit).
Suggested fix
Add a --page option to SearchCommand, defaulting to 1, validated as a positive integer the same way --limit is. Pass it to Slack.searchMessages(page:). Extend the (more results available) line to name the next page, for example (more results available: use --page 2).
Where
lib/src/cli/commands/search_command.dartlib/src/slack.dart — searchMessages(page:), already present
Found by the mutation review of #43 (review). Reported by Data, filed by Riker. This is a follow-up. It is not a regression from #43.
What happens
searchprints(more results available)when Slack reports more pages, but it gives the user no way to read them. The command always requests page 1.Slack.searchMessagesalready accepts apageparameter. Nothing in the CLI passes it. Data proved this by mutation: changing the facade to always send page 1 survives the whole test suite, because no test and no command ever asks for another page.Why this is worth fixing
The user is told more results exist and is then given no command to reach them. Raising
--limitis not an answer, because Slack capscountat 100 (see the sibling issue on--limit).Suggested fix
Add a
--pageoption toSearchCommand, defaulting to1, validated as a positive integer the same way--limitis. Pass it toSlack.searchMessages(page:). Extend the(more results available)line to name the next page, for example(more results available: use --page 2).Where
lib/src/cli/commands/search_command.dartlib/src/slack.dart—searchMessages(page:), already present