Fix #44 and adding way to configure custom formatter#47
Merged
Conversation
… of departure date formatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Etiquette
Changes
Tested
Description
This brings a fix to a switch up of handler and issuer in notice of departures. In addition, there is a new feature that allows the user to configure a custom
DateTimeFormatter, that will be used for the notice of departure feature only.You will have to add this line to your config right under the notice of departure active value (as shown in the screenshot):
Also, all mentions of the formatter in the translation has been replaced by the %formatter% tag, which will adapt to the current configured formatter, loaded after every restart. So make sure to reset you language files.