Version 2.35.0#649
Merged
Merged
Conversation
### Added - [SETTINGS] Allow importing custom and optional modules to the Django project ### Removed - [API_PARSER] Remove most of the code related to api collectors, now loaded as a separate module ### Fixed - [SETTINGS] Set and use correct REDIS HOST parameter value --------- Co-authored-by: Fabien Amelinck <fabien.amelinck@advens.fr>
… in python shells
This avoids having general errors being written in crontab.log instead of api_parser.log
| from services.frontend.models import (Frontend, FrontendReputationContext, Listener, COMPRESSION_ALGO_CHOICES, | ||
| LISTENING_MODE_CHOICES, LOG_LEVEL_CHOICES, MODE_CHOICES, DARWIN_MODE_CHOICES, | ||
| REDIS_MODE_CHOICES, REDIS_STARTID_CHOICES, | ||
| FILEBEAT_LISTENING_MODE, FILEBEAT_MODULE_LIST, SENTINEL_ONE_ACCOUNT_TYPE_CHOICES, |
Member
There was a problem hiding this comment.
We have an unused import here.
Suggested change
| FILEBEAT_LISTENING_MODE, FILEBEAT_MODULE_LIST, |
| from toolkit.api.responses import build_response, build_form_errors | ||
| from toolkit.http.headers import HeaderForm, DEFAULT_FRONTEND_HEADERS | ||
| from toolkit.api_parser.utils import get_api_parser | ||
| from toolkit.network.network import parse_proxy_url |
Member
There was a problem hiding this comment.
Same heren unused import.
Suggested change
| from toolkit.network.network import parse_proxy_url |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Removed
Fixed