fix(net2mongo): parsing of legacy netmask configuration#648
Merged
Conversation
ELDiablO59152
commented
Feb 6, 2026
frikilax
reviewed
Feb 11, 2026
frikilax
left a comment
frikilax
left a comment
Member
There was a problem hiding this comment.
Please add a unit test with extensive array of possible/impossible values to parse, especially to check pattern extraction (IP, netmask/prefix, CARP parameters, etc...)
frikilax
force-pushed
the
fix_netmask_parsing
branch
from
36b264c to
812662f
Compare
frikilax
force-pushed
the
fix_netmask_parsing
branch
from
812662f to
ed06846
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
See: #623