Skip to content

Overdue Chores Fix#51

Open
Wallexus wants to merge 4 commits into
VolantisDev:mainfrom
Wallexus:main
Open

Overdue Chores Fix#51
Wallexus wants to merge 4 commits into
VolantisDev:mainfrom
Wallexus:main

Conversation

@Wallexus

Copy link
Copy Markdown

As requested in #33, this is my attempt to fix #33. It's been quite some time, but I think essentially every chores were bypassing a check in calculate_day1, because today is calculated past midnight. I've left the check in, because I had trouble understanding the complete flow and added an additional check for day1 == start_date == last_completed, which will just increment day1.

I would appreciate, if this can be double-checked, but I've used this implementation for ~10 months now and never encountered this issue again.

WallSecurity and others added 4 commits February 29, 2024 08:56
Signed-off-by: Wallexus <167881799+Wallexus@users.noreply.github.com>
Signed-off-by: Wallexus <167881799+Wallexus@users.noreply.github.com>
@Wallexus

Copy link
Copy Markdown
Author

Oh, almost forgot: this also changes chore_helper.offset_date service call's date variable to optional, as stated in the README.

@odiseo123

Copy link
Copy Markdown

@bmcclure Hi Ben. Thanks for the cool tool. Are there any plans for another release, hopefully including this fix?

@purpleturtle1988

Copy link
Copy Markdown

I am also affected by this problem, is there any news on the release of the bug?

@Wallexus

Copy link
Copy Markdown
Author

This repo is (and, unfortunately, never really has been) no longer maintained. Feel free to use my fork to fix overdue chores, but I would honestly look for another integration to manage chores.

@purpleturtle1988

Copy link
Copy Markdown

This works great. Thank you. ❤️

@Lecso11

Lecso11 commented Jul 24, 2025

Copy link
Copy Markdown

This repo is (and, unfortunately, never really has been) no longer maintained. Feel free to use my fork to fix overdue chores, but I would honestly look for another integration to manage chores.

Hi! Can you help me how can I use your fork?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chores come overdue the day after completing them

5 participants