Skip to content

Release shiny2docker 0.0.4 (CRAN prep): expose renv_version + coverage 98%#14

Merged
VincentGuyader merged 1 commit into
mainfrom
feat/expose-renv-version
May 15, 2026
Merged

Release shiny2docker 0.0.4 (CRAN prep): expose renv_version + coverage 98%#14
VincentGuyader merged 1 commit into
mainfrom
feat/expose-renv-version

Conversation

@VincentGuyader

Copy link
Copy Markdown
Owner

Summary

  • Exposes renv_version parameter on shiny2docker(), forwarded to dockerfiler::dock_from_renv() (NULL -> bootstrap latest renv, skipping remotes).
  • Pins dockerfiler (>= 0.2.6), satisfied by dockerfiler 1.0.0 now on CRAN.
  • Bumps version to 0.0.4 and prepares CRAN submission (NEWS, cran-comments.md, .Rbuildignore).
  • Adds 27 unit tests, raising coverage from 58.82% to 98.04%.

Changes

Feature (already on this branch)

  • 192d8dc feat: expose renv_version param, forwarded to dock_from_renv
  • e2b0082 feat: pin dockerfiler (>= 0.2.6) and cover explicit renv_version branch

Release prep + coverage (new in this commit)

  • 73255ef chore(release): prepare shiny2docker 0.0.4 for CRAN
    • DESCRIPTION: version 0.0.3 -> 0.0.4, attachment sync, mockery added to Suggests, RoxygenNote 7.3.2 -> 7.3.3
    • NEWS.md: freeze # shiny2docker 0.0.4 section, document dockerfiler floor
    • cran-comments.md (new)
    • .Rbuildignore: add cran-comments.md, CRAN-SUBMISSION, doc, Meta
    • dev/config_attachment.yaml: pin renv and mockery in extra.suggests
    • tests/testthat/test-set_github_action.R (new, 9 tests)
    • tests/testthat/test-set_gitlab_ci.R (+6 tests)
    • tests/testthat/test-shiny2docker.R (+2 tests)

Coverage delta

File Before After
R/set_github_action.R 0.00% 96.15%
R/set_gitlab_ci.R 68.42% 100.00%
R/shiny2docker.R 89.47% 97.37%
Global 58.82% 98.04%

CRAN readiness

Check Result
R CMD check --as-cran 0 errors / 0 warnings / 0 notes
devtools::test() 39 PASS / 0 FAIL / 0 SKIP
Coverage 98.04%
pr-reviewer agent APPROVE
security-review agent Safe to ship

Security review: 0 Critical/High findings. Two Low items noted for a future patch (input validation on renv_version and GitLab tags; both are self-injection on the developer's own machine, outside the trust model). Pre-existing .dockerignore gap (does not exclude .Renviron/.env/keys) flagged for a 0.0.5 release.

Before merge / CRAN push

  • cran-comments.md lists GitHub Actions, R-hub, win-builder as test environments. Either run them for real (recommended: devtools::check_win_devel() + devtools::check_win_release() + rhub::check_for_cran()) and keep the list, or trim to what was actually executed before pressing submit.
  • After CRAN acceptance, tag v0.0.4.

Test plan

  • devtools::test() -> 39 PASS
  • devtools::check(args = "--as-cran") -> 0/0/0
  • covr::package_coverage() -> 98.04%
  • devtools::check_win_devel() (to run before submit_cran)
  • devtools::check_win_release() (to run before submit_cran)
  • rhub::check_for_cran() (to run before submit_cran)

* Bump version 0.0.3 -> 0.0.4, freeze NEWS section.
* Sync DESCRIPTION via attachment; keep renv in Suggests via extra.suggests.
* Add cran-comments.md.
* Add mockery to Suggests for new defensive-branch tests.
* Raise coverage 58.82% -> 98.04% (12 -> 39 tests) by covering
  set_github_action (was 0%), set_gitlab_ci defensive paths, and
  missing-path branches in shiny2docker.
* Rbuildignore: cran-comments.md, CRAN-SUBMISSION, doc, Meta.

R CMD check --as-cran: 0 errors | 0 warnings | 0 notes.
@VincentGuyader VincentGuyader force-pushed the feat/expose-renv-version branch from 73255ef to a5cb12b Compare May 15, 2026 14:21
@VincentGuyader VincentGuyader merged commit 420edfb into main May 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant