Release shiny2docker 0.0.4 (CRAN prep): expose renv_version + coverage 98%#14
Merged
Conversation
* Bump version 0.0.3 -> 0.0.4, freeze NEWS section. * Sync DESCRIPTION via attachment; keep renv in Suggests via extra.suggests. * Add cran-comments.md. * Add mockery to Suggests for new defensive-branch tests. * Raise coverage 58.82% -> 98.04% (12 -> 39 tests) by covering set_github_action (was 0%), set_gitlab_ci defensive paths, and missing-path branches in shiny2docker. * Rbuildignore: cran-comments.md, CRAN-SUBMISSION, doc, Meta. R CMD check --as-cran: 0 errors | 0 warnings | 0 notes.
73255ef to
a5cb12b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renv_versionparameter onshiny2docker(), forwarded todockerfiler::dock_from_renv()(NULL-> bootstrap latest renv, skippingremotes).dockerfiler (>= 0.2.6), satisfied by dockerfiler 1.0.0 now on CRAN.Changes
Feature (already on this branch)
192d8dcfeat: exposerenv_versionparam, forwarded todock_from_renve2b0082feat: pindockerfiler (>= 0.2.6)and cover explicitrenv_versionbranchRelease prep + coverage (new in this commit)
73255efchore(release): prepare shiny2docker 0.0.4 for CRANmockeryadded to Suggests, RoxygenNote 7.3.2 -> 7.3.3# shiny2docker 0.0.4section, document dockerfiler floorcran-comments.md,CRAN-SUBMISSION,doc,Metarenvandmockeryinextra.suggestsCoverage delta
R/set_github_action.RR/set_gitlab_ci.RR/shiny2docker.RCRAN readiness
R CMD check --as-crandevtools::test()Security review: 0 Critical/High findings. Two Low items noted for a future patch (input validation on
renv_versionand GitLabtags; both are self-injection on the developer's own machine, outside the trust model). Pre-existing.dockerignoregap (does not exclude.Renviron/.env/keys) flagged for a 0.0.5 release.Before merge / CRAN push
cran-comments.mdlists GitHub Actions, R-hub, win-builder as test environments. Either run them for real (recommended:devtools::check_win_devel()+devtools::check_win_release()+rhub::check_for_cran()) and keep the list, or trim to what was actually executed before pressing submit.v0.0.4.Test plan
devtools::test()-> 39 PASSdevtools::check(args = "--as-cran")-> 0/0/0covr::package_coverage()-> 98.04%devtools::check_win_devel()(to run before submit_cran)devtools::check_win_release()(to run before submit_cran)rhub::check_for_cran()(to run before submit_cran)