fix: at ff in ff.c#9
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
reference/drivers/fat32/source/ff.c.Vulnerability
V-002reference/drivers/fat32/source/ff.c:1691Description: At ff.c:1691, the expression (DWORD)fs->csize * SS(fs) computes the allocation size szb. If fs->csize and SS(fs) are both attacker-controlled via filesystem metadata and their product exceeds UINT32_MAX (4,294,967,295), the DWORD multiplication wraps to a small value, causing ff_memalloc to allocate a much smaller buffer than intended. Subsequent writes into this undersized buffer overflow into adjacent heap memory. The overflow guard (>= MAX_MALLOC) only fires if the pre-overflow value is large enough, but the unguarded second use of fs->csize * SS(fs) in the else branch can also overflow.
Changes
reference/drivers/fat32/source/ff.cVerification
Automated security fix by OrbisAI Security