Repository navigation
Resolve high severity security vulnerabilities (v0.42.3) - #178
Merged
Merged
Conversation
- Bump axios from 1.11.0 to 1.15.2 (production dep) to patch 4 CVEs: prototype pollution, header injection, NO_PROXY bypass - Add resolutions for devDep vulnerabilities: @babel/traverse, braces, cross-spawn, flatted, json5, marked, minimatch, minimist, picomatch, semver Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…race-expansion, and ajv - Upgrade axios 1.15.2 → 1.18.0 (fixes 3 high CVEs: NO_PROXY bypass, ReDoS via cookie, resource allocation) - Pin form-data to 4.0.6 via resolutions (fixes high CVE: CRLF injection in multipart field names) - Pin brace-expansion to 1.1.15 via resolutions (fixes low CVE: ReDoS) - Pin ajv to 6.15.0 via resolutions (fixes moderate CVE: ReDoS via $data option) - Bump package version to 0.42.3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep v0.42.3, axios 1.18.0, and security resolutions from vuln-updates branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
amvertex
approved these changes
Jun 16, 2026
sksizer
added a commit
that referenced
this pull request
Oct 9, 2026
| Author | Host | When | | --- | --- | --- | | `Agent:(claude-opus-5-5)` | Cursor on SKs-MacBook-Pro.local | 2026-10-08 14:02 CDT | ## Summary This moves the SDK from axios 1.18.0 to **1.20.0**, clearing the critical and high axios findings a customer reported against `@vertexvis/api-client-node` 0.44.0. It also bumps the package to **0.44.1** so the publish workflow releases it. - `package.json`: `"axios": "1.20.0"` (still pinned exactly) and version `0.44.1`. - `yarn.lock`: only the axios entry and its `form-data ^4.0.6` range change. `form-data` still resolves to 4.0.6 through the existing resolution. - `client/version.ts`: `0.44.1`, synced by `scripts/version.sh` through `yarn version --no-git-tag-version`. No `v0.44.1` tag was created, so `detect_publish.sh` will publish on merge. - `common.ts`: adds `as Promise<R>` on `axios.request`. axios 1.20.0's types made `tsc` fail here with TS2527 (an inferred type references an unexported `unique symbol`). The same fix is added to `scripts/generate.sh` as a post-generation `sed`, alongside the existing ones, so regenerating the client keeps it. The published declarations match 0.44.0, apart from axios's own new defaulted fourth type parameter on `AxiosResponse`. ## Test Plan - `yarn install --frozen-lockfile`: passed. - `yarn lint`: passed. - `yarn verify`: passed. This covers the CJS and ESM builds, jest (10/10) and `verify.js`. - `yarn audit --groups dependencies`: before, 12 axios advisories (7 high, 5 moderate, all patched in >=1.20.0); after, 0 vulnerabilities. - `npm pack`: the tarball is `0.44.1`, and its `package.json` declares axios 1.20.0. - Declarations: diffed `dist/cjs/*.d.ts` against the 0.44.0 tarball from npm. The only change is axios's defaulted type parameter. - Smoke test against a local mock API, with axios 1.20.0 loaded from this branch: 41/41 assertions passed. - Covered: the OAuth client-credentials request (Basic auth and form body), Bearer and `user-agent: vertex-api-client-node/0.44.1` headers, `timeout` and a keep-alive `httpAgent` through `axiosOptions`, `createFile` plus an `application/octet-stream` upload with a byte-identical body, `getFile`, `deleteFile`, and a 404 surfaced through the response interceptor. - Eight broken-server modes all reported FAIL or INCONCLUSIVE rather than PASS. - **Not run:** the same smoke script against platdev, because no platdev API client credentials were available to the agent. It is ready for a person to run. ## Release Notes `@vertexvis/api-client-node` 0.44.1 updates its HTTP client dependency, axios, to 1.20.0, resolving the critical and high security advisories reported against axios 1.18.0. There are no API changes: upgrade the dependency and refresh your lockfile. ## Possible Regressions - axios 1.19 and 1.20 harden how config options are read, how errors for bad option values are reported, NO_PROXY matching, and keep-alive socket handling. The SDK uses a plain `axios.create` instance, one response interceptor, basic and Bearer auth, and octet-stream uploads. None of these touch the changed behavior; this is inferred from the release notes and was exercised against the mock. - The deprecated `CancelToken`, used by queued-job polling, still exists in 1.20.0. ## Dependencies - [vertex-api-client-node#182](#182) also bumps the package version, to 0.45.0. Whichever lands second has to rebase. Landing this one first ships the security fix as a patch release, without the spec changes. ## Related - [PLAT-9529](https://vertexvis.atlassian.net/browse/PLAT-9529) - The earlier axios bump: [vertex-api-client-node#178](#178) [PLAT-9529]: https://vertexvis.atlassian.net/browse/PLAT-9529?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Upgrading axios affects all HTTP traffic through the SDK; risk is moderated by a patch-level dependency bump and a type-only workaround, but runtime behavior could still shift with axios 1.19–1.20 hardening. > > **Overview** > Patches **@vertexvis/api-client-node** to **0.44.1** and upgrades the pinned **axios** dependency from **1.18.0** to **1.20.0**, addressing reported critical/high advisories on the prior version (lockfile updates include axios’s **form-data** range). > > axios **1.20.0**’s typings break compilation in `createRequestFunction` (`common.ts`); the PR adds `as Promise<R>` on `axios.request` and mirrors that in **`scripts/generate.sh`** so regenerated clients keep the fix. No public API surface changes beyond the version bump. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit fb7dc2f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
axios1.15.2 → 1.18.0 (direct dependency) to fix 3 high severity CVEs: NO_PROXY bypass via IPv4-mapped IPv6 addresses, ReDoS via cookie name injection, and unbounded resource allocationform-datato 4.0.6 via resolutions to fix high severity CRLF injection in multipart field names (transitive via axios)brace-expansionto 1.1.15 via resolutions to fix low severity ReDoS (transitive via eslint/jest → minimatch)ajvto 6.15.0 via resolutions to fix moderate severity ReDoS via$dataoption (transitive via eslint)Vulnerability details
axiosform-databrace-expansionajv$dataoption (patched ≥6.14.0)All 7 high severity vulnerabilities are resolved. Remaining 66 advisories are low/moderate in dev-only transitive dependencies (jest/eslint tooling).
Test plan
yarn installcompletes successfullyyarn testpasses (10/10 tests)yarn auditshows 0 high severity vulnerabilities (down from 7)🤖 Generated with Claude Code