Skip to content

fix: render bottom nav and user account menu in studio mobile drawer#126

Merged
Gautam25Raj merged 1 commit into
masterfrom
fix/studio-mobile-nav-gaps
Jun 11, 2026
Merged

fix: render bottom nav and user account menu in studio mobile drawer#126
Gautam25Raj merged 1 commit into
masterfrom
fix/studio-mobile-nav-gaps

Conversation

@Atharv-Shandilya

Copy link
Copy Markdown
Contributor
  • Include bottomNav group (API Keys, Settings) in mobile nav drawer
  • Replace static user info with AccountMenu component for full account access on mobile
  • Fix setState-in-effect lint errors in portfolio sidebar components

Description

Fixes two mobile navigation gaps in the Studio dashboard.

Bottom nav missing from mobile drawer — mainNav and supportNav were spread into the mobile nav list but bottomNav was omitted entirely, leaving API Keys and Settings unreachable on mobile. Added bottomNav to the spread.

No account actions on mobile — the mobile drawer showed the user's name and email in a static

with no interactivity. Replaced it with the existing AccountMenu component (already used in the desktop sidebar), giving mobile users access to Profile, Billing, Settings, and Logout.

Lint fixes (Portfolio) — three setState-in-effect errors in portfolio sidebar components:

PortfolioAppShell: lazy useState initializer reads localStorage directly, removing the need for an effect
WorkspaceNavigation / WorkspaceThemeControl: replaced useEffect → setMounted(true) with useSyncExternalStore, which returns false on the server and true on the client with no setState call

Linked Issue

#107

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🧪 Tests (adding or updating tests)

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

- Include bottomNav group (API Keys, Settings) in mobile nav drawer
- Replace static user info with AccountMenu component for full account access on mobile
- Fix setState-in-effect lint errors in portfolio sidebar components
@Gautam25Raj Gautam25Raj merged commit 5ab0d23 into master Jun 11, 2026
0 of 2 checks passed
@Gautam25Raj Gautam25Raj deleted the fix/studio-mobile-nav-gaps branch June 11, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Mobile navigation drawer omits Settings and API Keys pages, and lacks Profile/Logout actions

2 participants