Ensure desktop console binaries are produced#15
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| print_step "Building ${os}/${arch}..." | ||
| GOOS="${os}" GOARCH="${arch}" CGO_ENABLED=0 \ | ||
| go build -o "${output}" "${MAIN_PKG}" | ||
| go build -tags desktop -o "${output}" "${MAIN_PKG}" |
There was a problem hiding this comment.
The build script now always passes -tags desktop when compiling. In this repository the fyne.io/fyne/v2 dependency is replaced with a stub that does not render a usable GUI or accept input. Building with the desktop tag therefore produces binaries that immediately block waiting for a non-existent window (e.g. go run -tags desktop ./src never shows an interface and must be killed). Before this change the default !desktop build exposed a browser-based console that remained usable in headless environments. Unless the script also wires in the real Fyne toolkit, forcing the desktop tag results in non-interactive artifacts for Linux/Darwin builds.
Useful? React with 👍 / 👎.
| set "GOOS=!TARGET_OS!" | ||
| set "GOARCH=!TARGET_ARCH!" | ||
| go build -o "!TARGET_OUTPUT!" "!MAIN_PKG!" | ||
| go build -tags desktop -o "!TARGET_OUTPUT!" "!MAIN_PKG!" |
There was a problem hiding this comment.
The batch build uses the same unconditional go build -tags desktop … as the shell script. Because the repository still replaces fyne.io/fyne/v2 with a no-op stub, the resulting Windows executable hangs at startup with no UI and no HTTP console, which is a regression from the previous !desktop build. Consider only enabling the desktop tag when building with the real Fyne dependency or when a GUI is explicitly requested.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f7d976dff0832ca138bd4aed8edb4a