Use getHolder for book enchantments#5583
Open
Klisz wants to merge 1 commit into
Open
Conversation
Makes InfluenceEntry have an InfluenceLocations field instead of an Influence, and keeps its enchanted book stacks as empty optionals until setRecipe is called. This way, it can use the level's registry access instead of the hacky proxy, and therefore use the enchantment registry's own reference holders for the enchantments, rather than creating Direct holders for them. This closes VazkiiMods#5556, and also solves another small unreported issue I've noticed wherein pressing the recipe-lookup or uses-lookup key on an enchanted book doesn't bring up the relevant influencing recipes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes InfluenceEntry have an InfluenceLocations field instead of an Influence, and keeps its enchanted book stacks as empty optionals until setRecipe is called. This way, it can use the level's registry access instead of the hacky proxy, and therefore use the enchantment registry's own reference holders for the enchantments, rather than creating Direct holders for them. This closes #5556, and also solves another small unreported issue I've noticed wherein pressing the recipe-lookup or uses-lookup key on an enchanted book doesn't bring up the relevant influencing recipes.