Add sicd_help.recompute_deltak - #8
Merged
Merged
Conversation
pressler-vsc
requested review from
bombaci-vsc,
johnstob,
mstewart-vsc and
mtrachy
September 28, 2026 20:00
johnstob
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a method for estimating SICD's
Grid/*/DeltaK1andGrid/*/DeltaK2from the other SICD metadata in a method very similar to that done insarkit.verification._sicd_consistency.This seems like a reasonable candidate for
sarkit-processingas it is similar to other redundant metadata computations (e.g.sarkit.sicd.compute_scp_coa), although the standard doesn't spell out how to derive it in exacting terms (e.g. whether or not it should reflect the "FullImage" or (nonFull?)Image).If we can figure out how to meaningfully convey this distinction between standard-prescribed and standard-reference-implementation, then perhaps this could even move to sarkit.