Repository navigation
Share repeated engine test helpers and add a pin refresher - #468
Merged
Merged
Conversation
resolveOne(), saved() and restore() were redefined identically in 45, 42 and 8 engine test files. They now live once in GameTestCase. Editing a pinned test changes its SHA-256 in config/coverage-evidence.json, so add bin/refresh-source-pins.php (composer pins) to rewrite only the existing pins in place. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2SqPTWy8sMSFHkDL2C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Item 3 of the structural review. Tests and tooling only; no runtime code changes.
What changed
resolveOne(),saved()andrestore()were redefined byte-for-byte in 45, 42 and 8 engine test files. They now live once inGameTestCase. 95 copies removed, about 450 lines net.reload,resolveAll,put,prepare,fixture) are left where they are.bin/refresh-source-pins.php(composer pins). Editing a pinned file changes its SHA-256 inconfig/coverage-evidence.json; the script rewrites only the existing pins in place and leaves the rest of the manifest untouched.--checkreports drift without writing.AGENTS.mdand the continuation guide mention the command.Verification
vendor/bin/phpunit tests/Game tests/FunctionalCoverageLedgerTest.php: 2386 tests, 46160 assertions, 2 skipped (the existing missing-import skips). Pint clean ontestsandbin.Generated by Claude Code