Skip to content

Share repeated engine test helpers and add a pin refresher - #468

Merged
valzargaming merged 1 commit into
mainfrom
claude/project-thread-unhs00
Nov 12, 2026
Merged

valzargaming merged 1 commit into
mainfrom
claude/project-thread-unhs00

Conversation

@valzargaming

Copy link
Copy Markdown
Member

Requested by Val · project thread

Item 3 of the structural review. Tests and tooling only; no runtime code changes.

What changed

  • resolveOne(), saved() and restore() were redefined byte-for-byte in 45, 42 and 8 engine test files. They now live once in GameTestCase. 95 copies removed, about 450 lines net.
  • Only identical copies were moved. Helpers with differing bodies or signatures (reload, resolveAll, put, prepare, fixture) are left where they are.
  • New bin/refresh-source-pins.php (composer pins). Editing a pinned file changes its SHA-256 in config/coverage-evidence.json; the script rewrites only the existing pins in place and leaves the rest of the manifest untouched. --check reports drift without writing.
  • 50 test pins refreshed with that script. AGENTS.md and the continuation guide mention the command.

Verification

vendor/bin/phpunit tests/Game tests/FunctionalCoverageLedgerTest.php: 2386 tests, 46160 assertions, 2 skipped (the existing missing-import skips). Pint clean on tests and bin.


Generated by Claude Code

resolveOne(), saved() and restore() were redefined identically in 45, 42
and 8 engine test files. They now live once in GameTestCase.

Editing a pinned test changes its SHA-256 in config/coverage-evidence.json,
so add bin/refresh-source-pins.php (composer pins) to rewrite only the
existing pins in place.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WTP2SqPTWy8sMSFHkDL2C
Copilot AI balanced review requested due to automatic review settings November 12, 2026 23:01
@valzargaming valzargaming self-assigned this Nov 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@valzargaming
valzargaming merged commit 6a74a29 into main Nov 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants