Repository navigation
Add inactive DiscordPHP lobby roster control primitive - #98
Draft
valzargaming wants to merge 8 commits into
Draft
valzargaming wants to merge 8 commits into
valzargaming wants to merge 8 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…Social/LobbyRoster.php
…l-lobby-control.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Civ13/Civ13#5122. DiscordPHP is mandatory; native launcher SDK audio remains separate.
Adds an unwired backend primitive using actual DiscordPHP LobbyRepository promises: uint64 string ID validation, conservative 25-member target cap, removals before additions, stop-on-rejection, and per-instance in-flight exclusion. No bootstrap wiring, live endpoints, OAuth grants, channel links, permissions, deployment or live Discord calls.
Validation at 96677b0:
This is a foundational control primitive, NOT working VOIP or full chat migration. Production caller must implement authenticated world/session/character authority, consent, expiry/revocation, fresh remote rosters, ownership and cross-process serialization before use. The authorized target is a frozen snapshot: generation/expiry checks before grants and prioritized revocation are required before integration. See docs/social-lobby-control.md for explicit privacy/routing gaps. No merge or activation requested.