Skip to content

Add inactive DiscordPHP lobby roster control primitive - #98

Draft
valzargaming wants to merge 8 commits into
mainfrom
codex/social-lobby-control-5122
Draft

valzargaming wants to merge 8 commits into
mainfrom
codex/social-lobby-control-5122

Conversation

@valzargaming

@valzargaming valzargaming commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Part of Civ13/Civ13#5122. DiscordPHP is mandatory; native launcher SDK audio remains separate.

Adds an unwired backend primitive using actual DiscordPHP LobbyRepository promises: uint64 string ID validation, conservative 25-member target cap, removals before additions, stop-on-rejection, and per-instance in-flight exclusion. No bootstrap wiring, live endpoints, OAuth grants, channel links, permissions, deployment or live Discord calls.

Validation at 96677b0:

  • Offline Social lobby matrix passed PHP 8.3/8.4/8.5: dependency installation, platform requirements, affected PHP lint and 30 offline assertions each.
  • API documentation passed.
  • General dependency contracts passed. Portable startup contracts also passed. All four observed workflows passed at this head; this does not establish native/live behavior.
  • The initial matrix failed on the test subclass constructor signature; fixed to match AbstractRepositoryInterface, then all matrix jobs passed. Tests now also cover partial-removal failure, failed additions, synchronous exceptions, overlap exclusion, guard release, large IDs and actual newlines.
  • Local PHP execution unavailable because this cloud lacks PHP/Composer; validation used GitHub runners only, not desktop or live services.

This is a foundational control primitive, NOT working VOIP or full chat migration. Production caller must implement authenticated world/session/character authority, consent, expiry/revocation, fresh remote rosters, ownership and cross-process serialization before use. The authorized target is a frozen snapshot: generation/expiry checks before grants and prioritized revocation are required before integration. See docs/social-lobby-control.md for explicit privacy/routing gaps. No merge or activation requested.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant