Repository navigation
Seal the in-game verification relay and keep secrets out of URLs - #96
Merged
Merged
Conversation
/approveme without a ckey gives a private single-use code. The game's Verify Discord verb sends ckey + code as the discord_verify webhook; the primary bot redeems it (bans, age and alt review still apply), and a desktop bot with the read-only verifier relays it to the primary bot's HMAC-signed /verified/ingame endpoint (INGAME_VERIFY_TOKEN). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2R6s5HsPDzf2CSzzGM
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2R6s5HsPDzf2CSzzGM
start and bot.php warn instead of refusing when the default-branch check fails. update keeps any local composer.lock (stashing it only when the update changes composer.lock itself). New control.php repair: stash local edits, keep local commits on a backup branch, and fast-forward a clean main, for the launcher's Repair and update button. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2R6s5HsPDzf2CSzzGM
The desktop bot's relay to the primary bot is now encrypted end to end with AES-256-GCM under a key derived from INGAME_VERIFY_TOKEN, so a watcher on the plain-HTTP link can no longer read and race a live code. Answers are sealed and bound to their request. The game's discord_verify request is a POST with the webhook key in the X-Webhook-Key header and ckey/code in a JSON body; a key in the query string is refused. Tests cover rejection paths and secrets in logs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2R6s5HsPDzf2CSzzGM
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two findings from the security review of in-game Discord verification (#93).
INGAME_VERIFY_TOKEN. OpenSSL is already required by the portable profile. Someone watching the plain-HTTP link can no longer read a live code and race to redeem it.discord_verifyis nowPOST <WEBHOOK_ADDRESS>/discord_verify. The key goes in theX-Webhook-Keyheader and ckey/code go in a JSON body.HttpHandler::__isWhitelisted) accepts the header key on/webhook/paths.tests/local/ingame-verification.phpgrows from 39 to 66 checks.docs/ingame-verification.mdis updated.Verification:
php tests/local/ingame-verification.phppasses 66 checks, including under the CIdisable_functionsrun.tests/local/*.phppasses. The exceptions arelifecycle-wire,replica-worker,server-compatibilityandverification-tls, which fail the same way on unmodified main when run without CI arguments.Not verified live: a real desktop-to-primary relay over the network.
Generated by Claude Code