Skip to content

Exclude BYOND guest keys from player-list embeds - #118

Draft
valzargaming wants to merge 1 commit into
mainfrom
codex/hide-byond-guests-in-player-embeds
Draft

valzargaming wants to merge 1 commit into
mainfrom
codex/hide-byond-guests-in-player-embeds

Conversation

@valzargaming

Copy link
Copy Markdown
Member

Change

Exclude generated BYOND guest keys from player-list embeds and counts: current and historical rounds, single and grouped heartbeat status, and cached status. Match numbered native and web guest formats, including canonical ckeys and the legacy hyphenated spelling, without discarding accounts such as guestbuilder. Current and historical round embeds use the filtered list for Discord verification lookups too.

The display filter does not alter stored round records, raw cached rosters, or operational player counts used by the player-count channel.

Verification

PHP 8.4.27 with a fresh install from composer.lock (--no-dev --no-plugins --no-scripts). Seven PHP files passed lint and git diff --check passed. heartbeat.php, heartbeat-integration.php, heartbeat-playercount.php, heartbeat-roster.php and network/process-disabled command-fixes.php passed. The old source with the new tests reproduced guest leakage on current round, historical round and grouped roster. No live bot, game or Discord interaction.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant