Repository navigation
Exclude BYOND guest keys from player-list embeds - #118
Draft
valzargaming wants to merge 1 commit into
Draft
valzargaming wants to merge 1 commit into
valzargaming wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Exclude generated BYOND guest keys from player-list embeds and counts: current and historical rounds, single and grouped heartbeat status, and cached status. Match numbered native and web guest formats, including canonical ckeys and the legacy hyphenated spelling, without discarding accounts such as
guestbuilder. Current and historical round embeds use the filtered list for Discord verification lookups too.The display filter does not alter stored round records, raw cached rosters, or operational player counts used by the player-count channel.
Verification
PHP 8.4.27 with a fresh install from
composer.lock(--no-dev --no-plugins --no-scripts). Seven PHP files passed lint andgit diff --checkpassed.heartbeat.php,heartbeat-integration.php,heartbeat-playercount.php,heartbeat-roster.phpand network/process-disabledcommand-fixes.phppassed. The old source with the new tests reproduced guest leakage on current round, historical round and grouped roster. No live bot, game or Discord interaction.