Repository navigation
Name the region in round, save and shutdown notices - #116
Merged
Merged
Conversation
Every region of a group posts to the same bot server, so the notices all read "Persistence". The game now sends region_name; the bot shows it as "Persistence (North America)", cleaned so it cannot ping or break Markdown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2TDmMxH1ZbruCaHBHx
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Every Civ13 region of a group posts to one bot server, so save, build move and round notices all read "Persistence" with no region.
HttpServiceManager::noticeServerName()appends the game'sregion_name(sent by Civ13'swebhook_add_region) as "Persistence (North America)". It keeps only letters, digits and.,'()-, so it can neither ping nor break the bold Markdown; a missing, malformed or same-as-server name adds nothing.round_start,world_saveandshutdown_notice. Round lines now also name the server: "Roundxin Persistence (North America) has resumed from a save." / "New roundxhas started in ...!"Check:
php tests/local/ooc-webhook.php vendor/autoload.phpPASS.Generated by Claude Code