Skip to content

Name the region in round, save and shutdown notices - #116

Merged
valzargaming merged 1 commit into
mainfrom
claude/project-thread-wm2bsq
Nov 18, 2026
Merged

valzargaming merged 1 commit into
mainfrom
claude/project-thread-wm2bsq

Conversation

@valzargaming

Copy link
Copy Markdown
Member

Requested by Val · project thread

Every Civ13 region of a group posts to one bot server, so save, build move and round notices all read "Persistence" with no region.

  • HttpServiceManager::noticeServerName() appends the game's region_name (sent by Civ13's webhook_add_region) as "Persistence (North America)". It keeps only letters, digits and .,'()-, so it can neither ping nor break the bold Markdown; a missing, malformed or same-as-server name adds nothing.
  • Used by round_start, world_save and shutdown_notice. Round lines now also name the server: "Round x in Persistence (North America) has resumed from a save." / "New round x has started in ...!"
  • tests/local/ooc-webhook.php covers region names on all three, a hostile name, and a non-string name.

Check: php tests/local/ooc-webhook.php vendor/autoload.php PASS.


Generated by Claude Code

Every region of a group posts to the same bot server, so the notices all
read "Persistence". The game now sends region_name; the bot shows it as
"Persistence (North America)", cleaned so it cannot ping or break Markdown.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016WTP2TDmMxH1ZbruCaHBHx
Copilot AI balanced review requested due to automatic review settings November 18, 2026 14:12
@valzargaming valzargaming self-assigned this Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@valzargaming
valzargaming merged commit a369dc4 into main Nov 18, 2026
44 checks passed
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants