Repository navigation
Retry hosted verification soon after a failed fetch; warn once per outage - #114
Merged
Merged
Conversation
…tage The desktop bot reads verification from the hosted list. When the first fetch at boot failed, nothing retried for 30 minutes, so every relayed chat line went out as plain text and logged "Chat relay identity lookup unavailable". The periodic refresh also ran exactly at the 30-minute freshness limit, leaving a brief stale window every cycle. - Failed hosted refresh retries after 30, 60, 120, then 300 seconds; success resets the backoff and cancels the pending retry. - Hosted read-only refresh runs every 15 minutes, inside the freshness window. - The chat relay warning is logged once per outage, not per line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2UbZ584w2CXPdx7Vin
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Member
Author
|
2026-11-17: Head 6668777 admin-merged as 25c37ea after local checks passed. The failed hosted fetch now retries after 30/60/120/300 s, hosted refresh runs every 15 minutes, and the relay warning logs once per outage. Ran admin-verification-refresh.php (32 assertions) and chat-moderation.php, both new checks fail without the fix, plus all 37 local-profile.yml steps, verifier-integration.php and windows/hosted-verifier.php: all PASS. CI was not waited on per the project merge rule; I'll check main. Unverified: a live boot against the hosted endpoint. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Problem
After the 17:34 UTC restart on 2026-11-17 the desktop bot logged
Chat relay identity lookup unavailable; sending unverified display textonce per relayed chat line. The bot log shows why: the first hosted verification fetch after boot failed (available:false, has_valid_list:falseat 17:34:44, after two 10 s timeouts), and nothing retried for 30 minutes. While the list is unavailable,Verifier::get()throws and the relay sends plain text with no Discord author embed. Chat is never dropped, but identities are missing and the log floods: the same thing happened on 2026-11-16 01:02 to 02:02 (1,136 warnings from one failed refresh) and on 2026-11-17 04:28 to 05:28.The periodic refresh also ran exactly at the 1800 s freshness limit, so lookups went stale for about a second each cycle (e.g.
Skipped new-account checks ... Hosted verification unavailableat 12:58:15, one second before the refresh landed).Change
Verifier: a failed hosted refresh schedules a single retry after 30, 60, 120, then 300 s; success resets the backoff and cancels any pending retry. Scheduling errors are caught so they never reject a finished refresh or reach the event loop.Verifier: hosted read-only refresh period is 900 s (insideFRESH_SECONDS); non-hosted mode keeps 1800 s. The freshness window and authority rules are unchanged.GameServer::__gameChatRelay: the warning is logged once per outage and re-armed after a successful lookup.Tests
php tests/local/admin-verification-refresh.php vendor/autoload.php: PASS (32 assertions; new retry/backoff/reset checks fail without the fix).php tests/local/chat-moderation.php vendor/autoload.php: PASS (new once-per-outage check fails without the fix).run: phpsteps oflocal-profile.yml, plustests/verifier-integration.php,tests/windows/hosted-verifier.php,tests/local/ooc-auto-relay.php,tests/local/lobby-webhook.php: PASS.Not verified: a live boot against the hosted endpoint.
Generated by Claude Code