Repository navigation
Default the bot's log level to info and read log_level from the profile - #113
Merged
Merged
Conversation
The launcher's Civilizationbot tab can now set the portable profile's log_level (debug, info, notice, warning, error); LOG_LEVEL in the environment is the fallback, then info. An unknown value logs a warning and uses info, so it never stops the bot from starting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2RCuxRvGvvpCDsWSAZ
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Member
Author
|
2026-11-17: Merged after the local offline suites in the PR body passed (log-level, bootstrap, default-branch, portable, constructor, run.php and others). Launcher side is Civ13/Civ13#5931 (1.5.30). Not verified live: the running bot on the host picks this up after Update and a restart. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
Change
The bot logged at debug unconditionally. It now resolves its level at start from the portable profile's optional top-level
log_level, then theLOG_LEVELenvironment value, then info. The Civ13 launcher's Civilizationbot tab (launcher 1.5.30) setslog_level. Accepted values: debug, info, notice, warning, error (case and spaces ignored). An unknown value logs a warning and uses info, so it never blocks boot.Civ13class fallback loggers also default to info. The bot logs aLog level: ...notice right after boot.src/Civ13/LogLevelSetting.php(new, pure), required next to the other early bootstrap classes inbot.php.tests/windows/bootstrap.phpandtests/windows/default-branch.phpcopy the new file.tests/local/log-level.phpadded to the local-profile workflow; docs indocs/windows-test1714.md.Verification
PHP 8.3, after
composer install --no-dev --no-plugins --no-scripts:php tests/local/log-level.php,tests/windows/bootstrap.php,default-branch.php,portable.php,constructor.php(+--negative-control),lock-path-guard.php,hosted-verifier.php,tests/local/run.php,adminlist-files.php,access-list-sync.phpall pass.constructor.php --cache-negative-controlfails the same way on main in this container (root user). MonologLevel::fromNamechecked for all five names. Not run live.Generated by Claude Code