Repository navigation
Relay the join screen to the lobby channel both ways - #112
Merged
Merged
Conversation
The lobby webhook now checks the service key like the other chat routes and takes a kind: chat (the existing LOBBY line), join_screen and entered arrival notices. Plain messages in a server's lobby channel go to the game through SQL/discord2lobby.txt with the same eligibility, formatting and badword rules as Discord OOC; secondary shard regions are skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WTP2QxSKVCEeWYEHrcnJq
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Val · project thread
The server's
lobbychannel had nothing feeding it: the game never called/lobbymessage, and Discord messages there went nowhere. This PR pairs with Civ13/Civ13#5925./lobbymessagemoves tohandleLobbyWebhook. It checks the service key like the OOC/IC routes, validates the ckey, and takeskind:chat(default): the existing "LOBBY ckey: message" line, moderated like OOC.join_screen: "[time]Key is on the join screen."entered: "[time]Key entered the world."The arrival lines carry no identity lookup, and markdown in the key is escaped.
Plain messages in a server's lobby channel relay to
SQL/discord2lobby.txt(GameServer::LobbyMessage). They use the same eligibility, formatting, badword and 🔥-on-failure rules as Discord OOC. Secondary shard regions are skipped.Tests: new
tests/local/lobby-webhook.php(added to local-profile.yml), andtests/local/ooc-auto-relay.phpextended with lobby routing and the real IPC record. Everyphp tests/...command in local-profile.yml passes locally, excepttests/windows/packaged-exe-smoke.php, which needs a built Windows exe.Generated by Claude Code