[project-vvm-async-api] mainをsquashせずにマージする#520
Merged
Conversation
Docs: 事例紹介のvoicevoxcore.goを追加
Co-authored-by: PickledChair <PickledChair@users.noreply.github.com> Co-authored-by: Ryo Yamashita <qryxip@gmail.com>
* Python APIでは`panic=unwind`にする * C APIは`-C panic=abort`でビルドする
* windows-latestでなぜかdownload_testが落ちるのを修正 * a
* `__declspec(dllimport)`と関数定義の隙間の空行を消す * `fn.args="vertical"`を設定
Member
Author
|
テストはたぶん通るので忘れないうちにマージしちゃいます！ |
qryxip
reviewed
Jun 13, 2023
qryxip
left a comment
qryxip
left a comment
Member
There was a problem hiding this comment.
大丈夫そうです。後追いLGTM。
❯ git switch -d
HEAD is now at 5f6ee44 [project-vvm-async-api] mainをマージする (#516)
❯ git merge 40f6662b61a27bf35ab2c20dc2973e22fb9722ab
Merge made by the 'ort' strategy.
❯ git diff 40f6662b61a27bf35ab2c20dc2973e22fb9722ab && echo "$?"
0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@qryxip さんのPRを間違えてsquashマージしてしまったので、通常mergeをする用のPRです。
とくにreset --hardなどをせず、追加でmergeする感じで大丈夫なはず。