cbindgenのinclude_versionを有効化する#519
Merged
Hiroshiba merged 3 commits intoJun 12, 2023
Merged
Conversation
qryxip
commented
Jun 11, 2023
Comment on lines
-13
to
-14
| Windows) | ||
| cargo install cbindgen --version ${{ inputs.version }};; |
Member
Author
There was a problem hiding this comment.
このcompositeアクションはubuntu-latestの一箇所からしか呼ばれなくなりこの分岐も要らなくなったので、アクションごと削除してインラインに書くようにした。
Member
There was a problem hiding this comment.
ubuntuからどころか、そもそもこのcompositeが呼ばれなくなった感じかな？
cargo insfallで一緒に入るようになったんでしたっけ。便利。
↑勘違かも、直接コマンド実行する形…？
Member
Author
There was a problem hiding this comment.
はい。この真下のmacOS | Linux )の所をtest.ymlに直書きする形ですね…
Hiroshiba
approved these changes
Jun 12, 2023
Hiroshiba
left a comment
Hiroshiba
left a comment
Member
There was a problem hiding this comment.
LGTM！！
1箇所しか使われてないのでcompositeを崩すのはありかなと思いました！
バージョンをcargoから持ってくる周りがちょい大変だけど助かります！！
This was referenced Jun 12, 2023
Merged
Hiroshiba
added a commit
that referenced
this pull request
Jun 12, 2023
* Docs: 事例紹介にvoicevoxcore.goを追加 (#498) Docs: 事例紹介のvoicevoxcore.goを追加 * 間違った`char*`の解放を明示的に拒否する (#500) * Cargo.tomlをフォーマットする (#504) * Update rust toolchain 1.70.0 (#506) Co-authored-by: PickledChair <PickledChair@users.noreply.github.com> Co-authored-by: Ryo Yamashita <qryxip@gmail.com> * Rust APIのbuild.rsを抹消する (#508) * Python APIでは`panic=unwind`にする (#505) * Python APIでは`panic=unwind`にする * C APIは`-C panic=abort`でビルドする * READMEのスペースが足りてなかった (#511) * windows-latestでなぜかdownload_testが落ちるのを改修 (#517) * windows-latestでなぜかdownload_testが落ちるのを修正 * a * cbindgenに`fn.args=vertical`を設定し、`__declspec`の後の空行を消す (#518) * `__declspec(dllimport)`と関数定義の隙間の空行を消す * `fn.args="vertical"`を設定 * cbindgenの`include_version`を有効化する (#519) * cbindgenの`include_version`を有効化する * jobをリネーム * 誤字 --------- Co-authored-by: Kota Amasaka <in9lude@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PickledChair <PickledChair@users.noreply.github.com> Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
include_versionを有効化し、CIでxtaskとcbindgen.exeの結果を突き合せるとこではcbindgen.exeのバージョンをCargo.lockに合わせるようにします。こういうのはあった方がいいかなと思いました。
関連 Issue
その他
#497 とはコンフリクトしなくても #382 としそう…