Skip to content

ci: on.pull_request.pathsを設定#1272

Merged
qryxip merged 4 commits into
VOICEVOX:mainfrom
qryxip:pr/ci-set-on-pull-request-paths
Jan 5, 2026
Merged

ci: on.pull_request.pathsを設定#1272
qryxip merged 4 commits into
VOICEVOX:mainfrom
qryxip:pr/ci-set-on-pull-request-paths

Conversation

@qryxip

@qryxip qryxip commented Jan 4, 2026

Copy link
Copy Markdown
Member

内容

#382 で書かれたものをベースに、今のこのリポジトリに沿うようにする。

.github/以下については漏れが怖いので、一括で.github/**という形の指定にする。既存のon.pull_request.pathにも問題がある気がするが、あったとしても別PRでやることにする。

その他

Co-authored-by: Yuto Ashida <y-chan@y-chan.dev>

@Hiroshiba Hiroshiba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

設定する方針、良いと思います!!
ヌケモレすることによるテスト発見遅れがあるかもだけど、テストが回りまくるよりはマシそう。

AI君に漏れがないか検査してもらうと少し安心できるかもですね!
頼りないけどcopilot君にもレビュー頼んでみます。あとcodex君も頼ってみよう。

@Hiroshiba

Copy link
Copy Markdown
Member

@codex レビューしてください。

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds paths filters to the on.pull_request triggers in three GitHub Actions workflow files to optimize CI execution by only running workflows when relevant files are changed. This is based on issue #382 and adapted to the current repository structure. The .github/ directory is specified as .github/** to avoid missing any relevant changes.

  • Added path filters to test.yml workflow
  • Added path filters to generate_document.yml workflow
  • Added path filters to build_and_deploy.yml workflow

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/test.yml Added paths filter to trigger tests only when Rust code, cargo config, examples, models, or GitHub workflow files change
.github/workflows/generate_document.yml Added paths filter to trigger documentation generation only when core code, documentation files, or related configurations change
.github/workflows/build_and_deploy.yml Added paths filter to trigger build/deploy only when core code, build utilities, models, or related configurations change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/test.yml
Comment thread .github/workflows/generate_document.yml Outdated
Comment thread .github/workflows/build_and_deploy.yml Outdated
Comment thread .github/workflows/generate_document.yml Outdated
qryxip and others added 3 commits January 5, 2026 08:51
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@qryxip

qryxip commented Jan 5, 2026

Copy link
Copy Markdown
Member Author

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@qryxip qryxip merged commit 60b423c into VOICEVOX:main Jan 5, 2026
30 checks passed
@qryxip qryxip deleted the pr/ci-set-on-pull-request-paths branch January 5, 2026 03:33
qryxip added a commit that referenced this pull request Jan 9, 2026
#1272 で得られた気付きをもとに、足りてなかったと思われるパターンを埋め
る。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants