Skip to content

Fix PR 38 review comments #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GernotMaier merged 1 commit into from
Oct 4, 2026
Merged

Fix PR 38 review comments #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion release_tests/lookuptable-testing/test_tables.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
# Supply a reference observation matched to the tables under test.
VERSION=$(cat "$VERITAS_EVNDISP_AUX_DIR/IRFVERSION") || exit 1
TESTFILE=${1:-${TESTFILE:-}}
TESTFILE=${1:-${TESTFILE:-$VERITAS_USER_DATA_DIR/analysis/Results/${VERSION}/Crab/evndisp/64080.root}}
[[ -s $TESTFILE ]] || { echo "Usage: $0 <reference evndisp ROOT file> (or set TESTFILE)" >&2; exit 1; }
ODIR="$VERITAS_USER_DATA_DIR/analysis/Results/$VERSION/table-tests"
mkdir -p "$ODIR" || exit 1
Expand Down
6 changes: 3 additions & 3 deletions release_tests/montecarlo/irf_plotting/irf_plotting.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ do
TESTED=$((TESTED+1))
if [[ -n $COMPAREVERSION ]]; then
COMPARESIMTYPE=${COMPARESIMTYPE:-$SIMTYPE}
COMPARECUT=${COMPARECUT:-$CUT}
COMPARE_CUT_FOR_CASE=${COMPARECUT:-$CUT}
COMP_IRFDIR=${IRFDIR//"$VERSION"/"$COMPAREVERSION"}
COMP_IRFDIR=${COMP_IRFDIR//"$SIMTYPE"/"$COMPARESIMTYPE"}
COMP_IRFFILE=${IRFFILE//"$SIMTYPE"/"$COMPARESIMTYPE"}
# compare TMVA with XGB file
COMP_IRFDIR=${COMP_IRFDIR//"$CUT"/"$COMPARECUT"}
COMP_IRFFILE=${COMP_IRFFILE//"$CUT"/"$COMPARECUT"}
COMP_IRFDIR=${COMP_IRFDIR//"$CUT"/"$COMPARE_CUT_FOR_CASE"}
COMP_IRFFILE=${COMP_IRFFILE//"$CUT"/"$COMPARE_CUT_FOR_CASE"}
echo "COMPIRFDIR (comparison): $COMP_IRFDIR"
echo "COMPIRFFILE (comparison): $COMP_IRFFILE"
root -l -q -b "plot_irf.C(\"${IRFDIR}\",\"${IRFFILE}\",\"${E}\",\"${A}\",\"${CUT}\",\"${Z}\",\"${W}\",\"${N}\",\"${MCAZ}\",\"${ODIR}\", \"${COMP_IRFDIR}\",\"${COMP_IRFFILE}\")"
Expand Down
Loading