Repository navigation
Fix/review f35 parameterize release coverage - #38
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documented lookup-table check is not runnable, and the IRF comparison fallback can select the wrong cut.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates release diagnostics to cover configured IRF cuts and lookup tables instead of hardcoded selections.
Changes:
- Iterates IRF plotting across configured cuts with optional comparisons.
- Requires a reference ROOT file for lookup-table validation.
- Reports tested, skipped, and failed combinations.
| File | Summary | Findings |
|---|---|---|
release_tests/montecarlo/irf_plotting/irf_plotting.sh |
Parameterized IRF coverage and comparison plotting. | Moderate per-cut comparison bug when COMPARECUT is omitted; README lacks the new environment interface (nit). |
release_tests/lookuptable-testing/test_tables.sh |
Validates lookup tables against a supplied reference file. | Critical: documented ./test_tables.sh invocation provides no reference input and exits before testing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release diagnostics silently cover only hardwired selections