v492.0 dev7

.gitignore

@@ -1 +1,2 @@
 .DS_Store
+tmpdir

.pre-commit-config.yaml

@@ -1,7 +1,7 @@
 repos:
   # https://pycqa.github.io/isort/docs/configuration/black_compatibility.html#integration-with-pre-commit
   - repo: https://github.com/pycqa/isort
-    rev: 9.0.0a3
+    rev: 9.0.1
     hooks:
       - id: isort
         args: ["--profile", "black", "--filter-files"]
@@ -12,7 +12,7 @@ repos:
         args: ["--line-length=100"]
   # https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html?highlight=other%20tools#flake8
   - repo: https://github.com/PyCQA/flake8
-    rev: 7.3.0
+    rev: 7.4.1
     hooks:
       - id: flake8
         args: ["--max-line-length=100", "--extend-ignore=E203,E712"]

README.md

@@ -20,9 +20,10 @@ Simplified overview of the testing (somewhat outdated):
 
 ## Abbreviations
 
-- SZE = small zenith angles (0-40deg)
-- MZE = medium zenith angles (40-50 deg)
-- LZE = large zenith angles (50-70 deg)
+- SZE = small zenith angles (0-30deg)
+- MZE = medium zenith angles (30-45 deg)
+- LZE = large zenith angles (45-55 deg)
+- BZE = beyond reasonable zenith angles (>55 deg)
 
 ## Directory structure
 

environment.yml

@@ -2,6 +2,9 @@ name: eventdisplay-release-tests
 channels:
   - conda-forge
 dependencies:
+  - python>=3.8
+  - numpy
+  - matplotlib
   - pandoc
   - pre-commit
   - towncrier
@@ -11,3 +14,4 @@ dependencies:
 # activate: conda activate eventdisplay-release-tests
 # update (conda/mamba): conda env update -f environment.yml --prune
 # update (micromamba): micromamba update -f environment.yml
+# update (micromamba): micromamba update -n eventdisplay-release-tests -f environment.yml

release_tests/montecarlo/irf_plotting/irf_plotting.sh

@@ -18,6 +18,7 @@ CUT="NTel3-PointSource-Hard-TMVA-BDT"
 CUT="NTel2-PointSource-Soft-TMVA-BDT"
 CUT="NTel2-PointSource-Moderate-TMVA-BDT"
 CUT="NTel2-PointSource-Moderate"
+echo "WARNING: CUT is hardwired to $CUT (for now)"
 # Comparison plots - version and simtype hardwired
 COMPAREVERSION="v492"
 COMPARESIMTYPE="CARE_202404"

release_tests/montecarlo/mc_data_comparison/README.md

@@ -1,20 +1,97 @@
-# MC / data comparison
+# MC / Data Comparison
 
-Scripts and tools to compare MC distributions with results from the Crab Nebula.
+**No apptainer usage!**
 
-Fill and plot distributions with
+Scripts and tools to compare Monte Carlo (MC) distributions with observational results from the Crab Nebula.
+
+## Quick Start
 
 ```console
-./compareDatawithMC.sh <runparameter file> <SZE/MZE/LZE/WOBBLE>
+./compareDatawithMC.sh <runparameter file> <SZE|MZE|LZE|WOBBLE>
 ```
 
-Requires as input:
+Where `<SZE|MZE|LZE|WOBBLE>` specifies the observation conditions:
+
+- `SZE`: Small zenith angles (0-25°, 0.5° wobble)
+- `MZE`: Medium zenith angles (40-50°, 0.5° wobble)
+- `LZE`: Large zenith angles (50-70°, 0.5° wobble)
+- `WOBBLE`: Large wobble offsets (MC at 1° wobble, summer atmosphere only)
+
+NOTE! The zenith angle bins are different compared to those used in the Crab Nebula analysis.
+
+## Prerequisites
+
+### Input Data Requirements
+
+- MC simulation files for each minor epoch (organized by atmosphere type)
+- Crab Nebula mscw results and matching `*.mscw.xgb_stereo.root` files for each run
+- Run lists for Crab observations (generated separately)
+
+## Preparation Steps
+
+Before running the comparison, you must generate the Crab run lists:
+
+```console
+# From release_tests/sources/Crab/
+./runlist_generator_from_anasum_log.sh <run parameter file> <anasum-results-directory>
+```
+
+This generates run lists for minor epochs, zenith angle ranges, and atmosphere types.
+The run lists are saved in `EventDisplay_Release_<version>/Crab/runlists/`.
+
+## Running the Comparison
+
+### Step 1: Prepare Run Parameter File
+
+The `<run parameter file>` must contain the following fields (one per line):
 
-- MC files for each minor epoch
-- Crab mscw results for each minor epoch
+```text
+* VERSION         <eventdisplay_version>  # e.g., V6
+* SIMTYPE         <simulation_type>       # e.g., CARE, CARE_RedHV
+* ATMOSPHERE      <atmosphere_id>         # e.g., 61, 62 (repeat line for multiple values)
+* EPOCH           <epoch_id> [nsb]        # e.g., V6_2019_2020s 0
+* CRAB_NSB        <nsb_level>             # e.g., 0, 1, or NOTSET
+```
+
+The leading `*` is part of the parameter-file syntax. To provide multiple atmospheres or epochs, repeat the corresponding line. If `CRAB_NSB` is `NOTSET`, the script reads the per-epoch NSB value from the optional 4th field of each `* EPOCH ...` line.
+
+### Step 2: Execute Comparison
+
+```console
+cd release_tests/montecarlo/mc_data_comparison/
+./compareDatawithMC.sh <path/to/run\ parameter\ file> SZE
+```
+
+This will:
+
+1. Parse the run parameter file
+2. Locate MC simulation files based on epoch and atmosphere
+3. Find corresponding Crab observational data
+4. Submit Condor jobs for each combination
+5. Generate comparison plots as PDF files
+
+### Step 3: Monitor Progress
+
+- Condor jobs are submitted with resource requests: 4000MB RAM, 10GB disk
+- Temporary symbolic links are created in: `{output_dir}/tmp/{uuid}/`
+- **Note**: Temporary directories must be cleaned up manually after completion
+
+## Output Structure
+
+Results are written to:
+
+```text
+EventDisplay_Release_<version>/mc_data_comparison/<analysis_type><disp>/<simulation_type>/
+├── <epoch>_ATM<atm>_<ELE>_<wobble>_<nsb>/
+│   ├── mcdatacomparison.runparameter
+│   ├── mcdatacomparison.root
+│   ├── mcdatacomparison.log
+│   └── *.pdf                    # Comparison plots
+└── tmp/                         # Temporary symlinks (manual cleanup required)
+```
 
-**important:**
-first run linking of epochs from `../../sources/Crab/`: `./runlist_generator.sh V6`
-(or for any other epoch)
+## Special Cases
 
-Output and plots are written as PDFs into the `../../../../EventDisplay_Release_<version>/mc_data_comparison/` directories
+- **CARE_RedHV simulations**: Handled with modified BDT cut (BDT=0 instead of 1)
+- **Summer vs Winter Atmosphere**: Automatically selected based on epoch suffix ('s' or 'w')
+- **Wobble Mode**: Forces atmosphere 61 and 1.0° wobble offset