invite for existing user#227
Open
Nikunjsharma0 wants to merge 70 commits into
Open
Conversation
…ks and introduce new subflows for common person-related actions. ### New Flows - `001_001b_invite_existing_users_using_invite_code_or_link_test.yaml`: Tests the end-to-end flow of inviting existing teachers, students, and family members using URLs and codes. ### New Subflows - `add_person_to_app.yaml`: Handles creating a new person profile within the app. - `create_account_for_person.yaml`: Handles setting up login credentials for an existing person profile. - `school_user_login_flow.yaml`: Standardizes the login process for school users. ### Refactoring and Improvements - Rename `001_001_invite_users_using_qr_code_or_link_test.yaml` to `001_001a_invite_new_users_using_qr_code_or_link_test.yaml` for consistency. - Rename `subflows/admin_add_class.yaml` to `subflows/user_add_class.yaml`. - Update class naming in existing tests from "New Class" to "TestClass". - Standardize script naming in `school_init.js` by removing the `.yaml` extension from the `NAME` environment variable.
…ks and introduce new subflows for common person-related actions. ### New Flows - `001_001b_invite_existing_users_using_invite_code_or_link_test.yaml`: Tests the end-to-end flow of inviting existing teachers, students, and family members using URLs and codes. ### New Subflows - `add_person_to_app.yaml`: Handles creating a new person profile within the app. - `create_account_for_person.yaml`: Handles setting up login credentials for an existing person profile. - `school_user_login_flow.yaml`: Standardizes the login process for school users. ### Refactoring and Improvements - Rename `001_001_invite_users_using_qr_code_or_link_test.yaml` to `001_001a_invite_new_users_using_qr_code_or_link_test.yaml` for consistency. - Rename `subflows/admin_add_class.yaml` to `subflows/user_add_class.yaml`. - Update class naming in existing tests from "New Class" to "TestClass". - Standardize script naming in `school_init.js` by removing the `.yaml` extension from the `NAME` environment variable.
…e-existing-user # Conflicts: # .maestro/flows/001_001a_invite_new_users_using_qr_code_or_link_test.yaml # .maestro/flows/subflows/school_user_login_flow.yaml
…r more comprehensive user interaction paths.
…_or_link_test.yaml` to clear app state before each login subflow to ensure test isolation.
…NAME}` and `${PASSWORD}`.
…ml` Maestro subflow.
…_or_link_test.yaml` to improve the reliability of toggling the "Approval required" switch and add assertions for the "Waiting for approval" state.
…_or_link_test.yaml` to use the "Paste URL" flow for student invites instead of the manual invite code entry.
…_or_link_test.yaml` to use the "Paste URL" flow for student invites instead of the manual invite code entry.
…_or_link_test.yaml` to copy the invite URL instead of the invite code.
…_or_link_test.yaml` to simplify assertions and remove redundant navigation steps when verifying accepted invites.
…_or_link_test.yaml` to simplify assertions and remove redundant navigation steps when verifying accepted invites.
…_or_link_test.yaml` to handle "Save password" prompts during login instead of after accepting invites, and correct a role assertion from "Student" to "Parent".
…_or_link_test.yaml` to handle "Save password" prompts during login instead of after accepting invites, and correct a role assertion from "Student" to "Parent".
…_or_link_test.yaml` to handle "Save password" prompts and re-enable several assertions for invitation acceptance and account status.
mikedawson
reviewed
May 15, 2026
| import world.respect.datalayer.http.school.SchoolUrlBasedDataSource | ||
| import world.respect.datalayer.schooldirectory.SchoolDirectoryEntryDataSource | ||
|
|
||
| class GetClassUseCaseClient ( |
Member
There was a problem hiding this comment.
Let's not make more http requests than needed: please move the name info required by the UI for the person waiting for an invite into metadata instead.
# Conflicts: # respect-app-compose/src/androidMain/kotlin/world/respect/AppKoinModule.kt
# Conflicts: # .maestro/flows/flows-disabled/003_admin_user_assigns_assignment_to_a_class_test.yaml # respect-datalayer/src/commonMain/kotlin/world/respect/datalayer/school/EnrollmentDataSource.kt # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/acceptinvite/AcceptInviteViewModel.kt # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/manageuser/accountlist/AccountListViewModel.kt # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/person/inviteperson/InvitePersonViewModel.kt # respect-lib-shared/src/jvmMain/kotlin/world/respect/shared/domain/account/invite/RedeemInviteUseCaseDb.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.