Dev playlists#175
Conversation
# Conflicts: # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/apps/launcher/AppLauncherViewModel.kt
# Conflicts: # respect-app-compose/src/commonMain/kotlin/world/respect/app/app/App.kt
| respectNavController: RespectComposeNavController, | ||
| onSetAppUiState: (AppUiState) -> Unit, | ||
| ) { | ||
| LaunchedEffect(Unit) { |
There was a problem hiding this comment.
This code must be removed immediately: this is not how set the title. This is done using the ViewModel. This is not following patterns. Please do not write code in clear violation of the existing patterns without checking with other developers first.
… to include Home navigation and verify Playlists visibility
… to include Home navigation and verify Playlists visibility
- Update Maestro test flows for improved playlist and section assertions. - Refactor `LearningUnitListScreen` to simplify multi-select UI and improve bottom button logic for playlist selection. - Update `LearningUnitListViewModel` to handle playlist picking mode, supporting `ReadiumLink` results and preventing multi-select of publications during playlist selection. - Improve `PlaylistEditViewModel` to correctly resolve playlist titles and navigation links when adding items to sections. - Refine section type detection in `PlaylistEditScreen` to properly distinguish between navigation and publication sections. - Remove redundant app bar state restoration calls in `PlaylistEditScreen`.
# Conflicts: # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/learningunit/list/LearningUnitListViewModel.kt # respect-lib-shared/src/commonMain/kotlin/world/respect/shared/viewmodel/playlists/mapping/edit/PlaylistEditViewModel.kt
… exceptions with early returns.
… exceptions with early returns.
| #- assertVisible: "Share link" | ||
| #- assertVisible: "Send link via SMS" | ||
| #- assertVisible: "Send link via email" | ||
| #- tapOn: |
There was a problem hiding this comment.
@mikedawson
This test will fail because when we tap on Copy Link, the user is navigated to the Enter Link screen and the link is copied to the system clipboard.
However, when attempting to paste into the input field, the paste command reads from the Maestro clipboard instead of the system clipboard.
As a result, it doesn’t get the correct URL and throws an “invalid URL” error.
mikedawson
left a comment
mikedawson
left a comment
There was a problem hiding this comment.
This must be reviewed carefully in accordance with coding guidelines, especially when it comes to the Don't Repeat Yourself principle (the very first thing at the top of the "very important" section of the coding guidelines
e.g. if there is a list do not have a separate variable for the count of the number of items. Use single point of truth, do not repeat, use the list's .size.
|
@lipsa-b as you mentioned this was not quite ready for review before, please add a comment here when you believe it is ready for review. |
|
Its ready for review. |
4 participants
No description provided.