-
Notifications
You must be signed in to change notification settings - Fork 0
Bookmark (Lesson / Playlist) #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mandvii
wants to merge
128
commits into
main
Choose a base branch
from
dev-bookmark
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
128 commits
Select commit
Hold shift + click to select a range
393e3ca
Add bookmark button to lesson details
Mandvii 9e42c09
Add bookmark functionality for learning units
Mandvii a68f0e9
feat: Add bookmark data layer
Mandvii 0ae16f0
feat: Implement fetching of bookmarked publications
Mandvii 4406a0d
feat: Store title and timestamp for bookmarks
Mandvii fd029c8
Implement fetching of all bookmarks
Mandvii 9c02d1d
Display app name and icon on learning unit detail screen
Mandvii 09b187c
Store subtitle and app icon for bookmarks
Mandvii 5feb7e7
Store subtitle and app icon for bookmarks
Mandvii dd8a299
Improve code formatting in OpdsDataSourceDb
Mandvii d763ad9
Improve code formatting in OpdsDataSourceDb
Mandvii d036297
Implement bookmark list screen
Mandvii d00d1cc
Implement bookmark list screen
Mandvii c2646cb
Implement bookmark list screen
Mandvii 5969bc2
Implement bookmark list screen
Mandvii c5759f9
Implement bookmark list screen
Mandvii 1da8527
Implement bookmark list screen
Mandvii 3af9e3e
Refactor bookmarking logic to toggle status
Mandvii 20f36ad
Refactor bookmarking logic to toggle status
Mandvii 09c2012
Delete respect-datalayer-db/schemas/world.respect.datalayer.db.Respec…
Mandvii 406d7ef
Refactor bookmarking logic to toggle status
Mandvii 291bd51
Merge remote-tracking branch 'origin/dev-bookmark' into dev-bookmark
Mandvii 1cee040
Refactor bookmarking logic to toggle status
Mandvii 0fc296a
Refactor: Enhance bookmark data and enable navigation
Mandvii 53705ae
Seperation of bookmark implementation
Mandvii 05f1c48
Seperation of bookmark implementation
Mandvii 756bea7
Update bookmark data model to include learning unit URL
Mandvii 53e0a32
Update bookmark
Mandvii 1f7b843
Move bookmarking logic from respect app data source to school data so…
Mandvii 92d7bf7
Update bookmark logic to use enum to delete
Mandvii 426d2d8
Rename bookmark observation methods to getBookmarkStatus and getAllBo…
Mandvii 4a89f83
Rename bookmark observation methods to getBookmarkStatus and getAllBo…
Mandvii 2d04435
Refactor bookmarking logic to use Bookmark model and toggle status
Mandvii 2c23ba3
Refactor bookmarking logic to use Bookmark model and toggle status
Mandvii 77b9db3
Refactor bookmarking logic to use Bookmark model and toggle status
Mandvii 408f4f9
Refactor bookmarking logic to use Bookmark model and toggle status
Mandvii a9479f5
Rename Bookmark field learningUnitUrl to learningUnitManifestUrl
Mandvii 1e6948c
Rename Bookmark field learningUnitUrl to learningUnitManifestUrl
Mandvii 3a18efb
Added playlist test
poojaustad 945388f
Move bookmark-related database components to the school package
Mandvii 7afcba6
Move bookmark-related database components to the school package
Mandvii 84e0bb9
Added bookmark test
poojaustad 72b421e
Add user identification to bookmark database components
Mandvii 4627b71
Add user identification to bookmark database components
Mandvii 2cbfb67
Add user identification to bookmark database components
Mandvii 1f48819
Update bookmark storage logic
Mandvii 5a831e9
Implement bookmark toggling and update database components
Mandvii a938244
Refactor bookmark data layer to use unique identifiers and timestamps
Mandvii 10fd1a0
Refactor bookmark data layer to use composite primary keys and remove…
Mandvii 2887a2e
Refactor bookmark data layer to use composite primary keys and remove…
Mandvii de1672f
Clean up code and refactor bookmark icon logic
Mandvii a8090ad
Implement bookmark data layer including HTTP, DB, and Repository comp…
Mandvii fa14310
Merge remote-tracking branch 'origin/main' into dev-bookmark
Mandvii eec848c
Update Bookmark model and data layer to support titles, subtitles, an…
Mandvii cefb0fd
Remove title, subtitle, and image fields from Bookmark model and DAO …
Mandvii 3fc830e
Add localized title support to bookmarks and update database relations
Mandvii f56d2bb
Merge branch 'refs/heads/dev-playlist-datastore' into dev-bookmark
Mandvii a69e1d5
Refactor LearningUnitDetailViewModel and clean up unused imports and …
Mandvii 6327d37
Merge branch 'refs/heads/main' into dev-bookmark
Mandvii 465032c
Update Bookmark model and data layer to include subtitles and improve…
Mandvii ec445b7
Remove properties
Mandvii 3641ad3
Update BookmarkListViewModel to use LoadingUiState and clean up imports
Mandvii 18a483a
Update BookmarkListViewModel to use LoadingUiState and clean up imports
Mandvii e48f9fb
Update BookmarkListViewModel to use LoadingUiState and clean up imports
Mandvii 505f774
Update BookmarkListViewModel to use LoadingUiState and clean up imports
Mandvii 46d8fae
Clean up formatting in BookmarkDao
Mandvii 551976e
Clean up formatting in BookmarkAdapter.kt
Mandvii a8e6fe9
Clean up
Mandvii 82cc67a
Clean up
Mandvii 340352e
Clean up
Mandvii a4a6ee1
Clean up LearningUnitDetailViewModel constructor and improve code for…
Mandvii 32473c8
Add image URL support to Bookmark model and UI components
Mandvii 8c79863
Add BookmarkEntity to database schema and implement navigation to boo…
Mandvii 61d5542
Add BookmarkEntity to database schema and implement navigation to boo…
Mandvii a50d703
Add BookmarkEntity to database schema and implement navigation to boo…
Mandvii e57b885
Added lesson002 and updated test
poojaustad 3776aab
Merge branch 'main' into dev-bookmark
Mandvii 3a089ed
Implement bookmark navigation and fix data synchronization in Bookmar…
Mandvii 6017f39
Update bookmark implementation to include application manifest URLs a…
Mandvii 83f07a7
commented bookmark code for playlist screen
poojaustad 1be340c
Merge remote-tracking branch 'origin/dev-bookmark' into dev-bookmark
poojaustad cd595d2
commented bookmark code for playlist screen
poojaustad 7df21b5
Update bookmark implementation to include application manifest URLs a…
Mandvii f0a839a
Update bookmark data layer, database entities, and cleanup ViewModel …
Mandvii 915e6a7
Rename findBookmarks to findBookmarksWithMissingPublication and updat…
Mandvii 58a867f
Merge branch 'dev-playlist-datastore' into dev-bookmark
Mandvii b989e62
Implement getBookmarkLastModified and findByUidList in BookmarkDao an…
Mandvii f8f9681
Merge branch 'main' into dev-bookmark
Mandvii bb55e8c
Register Bookmark components in RespectSchoolDatabase and update OPDS…
Mandvii 956911b
Register Bookmark components in RespectSchoolDatabase and update OPDS…
Mandvii 7374b28
Add language, grade, and type fields to Bookmark model and display th…
Mandvii 251b0b7
Merge remote-tracking branch 'origin/main' into dev-bookmark
Mandvii df53eb3
Update navigation labels to "Home" and integrate BookmarkListScreen i…
Mandvii e0a1910
Update navigation labels to "Home" and integrate BookmarkListScreen i…
Mandvii 7d04240
Add NO_BOOKMARK to RespectImage and update EmptyBookmarkState UI in B…
Mandvii fcbc40a
Add NO_BOOKMARK to RespectImage and update EmptyBookmarkState UI in B…
Mandvii cbc120e
Add NO_BOOKMARK to RespectImage and update EmptyBookmarkState UI in B…
Mandvii e200adb
Add NO_BOOKMARK to RespectImage and update EmptyBookmarkState UI in B…
Mandvii 7277a7e
Update UI layout and styling in BookmarkListScreen.kt
Mandvii dd7368e
Update UI layout and styling in BookmarkListScreen.kt
Mandvii b4ec210
Move no_bookmark image to shared resources and update BookmarkListScr…
Mandvii f24061c
Implement `listAsFlow` in `BookmarkDataSource` and update `BookmarkLi…
Mandvii c6cc3cb
Implement paging support for BookmarkDataSource across DB, HTTP, and …
Mandvii 6281ac5
Merge branch 'main' into dev-bookmark
Mandvii 4c42ab5
Remove redundant comments in BookmarkListViewModel
Mandvii 04937cf
Introduce `BookmarkDetails` to associate bookmarks with their corresp…
Mandvii dc3d660
Merge branch 'main' into dev-bookmark
Mandvii 5e28414
Update Maestro flows
poojaustad f92f9ac
test - update Maestro flow for lesson browsing
poojaustad c023520
Update Maestro test flows
poojaustad 963819a
Update Maestro test flows
poojaustad b0e1d42
Update Maestro test flows
poojaustad 18db69f
Update BookmarkDataSource and related components to support includeDe…
Mandvii 59b3ee0
Update SnackBar implementation to support actions and implement undo …
Mandvii 3ac5d63
Implement `UiText.asString()` extension and update `Snack` to support…
Mandvii cacf36f
Use default snackbar duration in App.kt
Mandvii 95bd635
test is failing as Snack bar appears but due to duration by the time …
Mandvii 45afefc
test: Update browse lessons Maestro flow with additional assertions
poojaustad 724721d
Merge remote-tracking branch 'origin/dev-bookmark' into dev-bookmark
poojaustad a2661f1
test: update browse lessons Maestro flow
poojaustad 989766b
Updated `002_browse_lessons_test.yaml` Maestro flow
poojaustad a64a053
test: update Maestro browse lessons flow
poojaustad 999dd99
test is failing as Snack bar appears but due to duration by the time …
Mandvii 005b914
Format code and apply style improvements across bookmark and data lay…
Mandvii e4c17e8
Update icon URI handling in Bookmark and LearningUnit detail screens …
Mandvii 7383793
Update snackbar message handling to support StringUiText and StringRe…
Mandvii 853b18e
Update snackbar message handling to support StringUiText and StringRe…
Mandvii 6183d47
Update bookmark query field and remote sync logic.
Mandvii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poojaustad please ensure that the tests are in the appropriate branch. This does not look like a bookmark test.