Repository navigation
fix: remove MSDK-4831 SPM vendor workaround, point back at remote tags - #217
Draft
islameldesoky95 wants to merge 1 commit into
Draft
islameldesoky95 wants to merge 1 commit into
islameldesoky95 wants to merge 1 commit into
Conversation
mobile-sdk's MSDK-4831 (corrupted Package.swift Sentry placeholder) and MSDK-4862 (iOS launch crash on Sentry version drift) fixes are merged and published. The vendored local copies of usercentrics-spm-sdk/-ui (Vendor/usercentrics-spm-sdk, Vendor/usercentrics-spm-ui — added in 32bc5bf, 012edf4) are no longer needed: restores Package.swift to the original remote .package(url:) dependencies this plugin used before the workaround, and deletes the Vendor/ directory entirely. NOT YET MERGED — holding until the exact published mobile-sdk version (currently assumed 2.32.1, needs confirmation) is verified real via `swift package resolve` against the actual remote tags, not just parsed locally via `swift package dump-package`. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mobile-sdk's MSDK-4831 (corrupted
Package.swiftSentry placeholder — invalid semver shipped in the published 2.32.0 SPM artifact, brokeswift package resolvefor every consumer) and MSDK-4862 (iOS launch crash on Sentry version drift) fixes are merged into mobile-sdk'sdevelopbranch (PR #2544).This removes the temporary vendoring workaround added in 32bc5bf / 012edf4:
ios/usercentrics_sdk/Vendor/usercentrics-spm-sdkandVendor/usercentrics-spm-uientirely.Package.swiftto the original remote.package(url:)dependencies this plugin used before the workaround.This is staged ahead of time and depends on mobile-sdk actually publishing a corrected release (expected
2.32.1, not yet published as of this PR). The version pin inPackage.swiftis currently set to2.32.1as a placeholder — confirm this matches the real publishedusercentrics-spm-sdk/usercentrics-spm-uitag (and thatswift package resolvesucceeds against the real remote repos, not justswift package dump-packagelocally) before merging.Test plan
swift package dump-packageconfirms the manifest parses correctly and points at the real remote URLs with an exact version pin.swift package resolveagainst the actual published tag (blocked until mobile-sdk 2.32.1 ships).flutter build ios/example app build once resolvable.🤖 Generated with Claude Code