fix: add missing signature response headers to get_order#370
Merged
igrigorik merged 3 commits intoJun 12, 2026
Merged
Conversation
The get_order operation was the only REST endpoint missing Signature, Signature-Input, and Content-Digest response headers. All other operations (checkout, cart, catalog, get_product) already declare these headers, enabling codegen tools to surface signature verification and signaling to implementors that responses should be signed per the signatures spec. Closes Universal-Commerce-Protocol#364 Made-with: Cursor
3 tasks
damaz91
approved these changes
Jun 11, 2026
drewolson-google
approved these changes
Jun 12, 2026
Contributor
|
@jingyli non-blocking, did you audit if there are any other places we might be missing it? |
Contributor
|
@igrigorik Yes, from openapi side, this is the last fix needed. Though a meta-point is that we don't have representation of signature headers definition in our openrpc file despite documentation mentioning it is supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_order operation was the only REST endpoint missing Signature, Signature-Input, and Content-Digest response headers. All other operations (checkout, cart, catalog, get_product) already declare these headers, enabling codegen tools to surface signature verification and signaling to implementors that responses should be signed per the signatures spec.
Closes #364
Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.
Type of change