Skip to content

docs: remove spurious fulfillment-option from checkout documentation#284

Merged
damaz91 merged 1 commit into
Universal-Commerce-Protocol:mainfrom
leoneperdigao:ucp/101-bug-spurious-model-fulfillment-option-in-the
Jun 11, 2026
Merged

docs: remove spurious fulfillment-option from checkout documentation#284
damaz91 merged 1 commit into
Universal-Commerce-Protocol:mainfrom
leoneperdigao:ucp/101-bug-spurious-model-fulfillment-option-in-the

Conversation

@leoneperdigao

Copy link
Copy Markdown
Contributor

Description

Remove the spurious Fulfillment Option entity section from the Checkout capability documentation. This entity is a child of fulfillment_group and belongs exclusively in the Fulfillment Extension documentation, where it is already properly documented.

As reported in #101, the Fulfillment Option model appears in the checkout page's Table of Contents but is not referenced or linked from any other section of the checkout documentation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Fixes #101

@leoneperdigao leoneperdigao requested review from a team as code owners March 20, 2026 19:38
@google-cla

google-cla Bot commented Mar 20, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@damaz91 damaz91 force-pushed the ucp/101-bug-spurious-model-fulfillment-option-in-the branch from c2062e8 to f0404dc Compare April 17, 2026 10:21
@damaz91

damaz91 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@leoneperdigao can you please rebase this change on top of the latest version of checkout.md so we can merge? Thanks!

The Fulfillment Option entity was incorrectly included in the Checkout
capability documentation. It is a child entity of fulfillment_group and
belongs exclusively in the Fulfillment Extension documentation where it
is already properly documented.

Fixes Universal-Commerce-Protocol#101
@leoneperdigao leoneperdigao force-pushed the ucp/101-bug-spurious-model-fulfillment-option-in-the branch from f0404dc to 665cf31 Compare June 11, 2026 10:29
@leoneperdigao

Copy link
Copy Markdown
Contributor Author

@damaz91 done!

@damaz91 damaz91 merged commit dd7daed into Universal-Commerce-Protocol:main Jun 11, 2026
15 checks passed
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 11, 2026
@leoneperdigao leoneperdigao deleted the ucp/101-bug-spurious-model-fulfillment-option-in-the branch June 11, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Spurious model (fulfillment-option) in the checkout documentation

4 participants