Repository navigation
Conversation
Whether someone is away when assigned, the conflict flags on their assignments and the absences named while picking a person now read Absence by the person's record, instead of day-off events through the declaring account's record. Same answers: the references are unchanged. An absence row is enough on its own; a day-off event without one, as the previous version wrote during the rollout, no longer counts — the catch-up before the events are dropped copies it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1b of the event schedules plan (#533): the conflict readers read absences from their own table (#566).
What changes
Three readers move from day-off events, found through the declaring account's record, to
Absencerows found by the person's record:checkDayOffConflict: whether someone is away when they are assigned, which blocks the assignment on a published programme and flags it on a draft;refreshConflictFlags: the conflict flags on a person's assignments when they declare or delete an absence;listSlotCandidateFacts: the absence named next to a person in the list of people to pick from.list-user-conflicts-in-rangereads the stored flags, so it follows without a change.Same answers as before:
Absencerow carries that record, and linking an account to a record moves its rows too.References
Unchanged. All 35 reference tests come back byte-identical.
Rollout
During the rollout, the previous version can still declare an absence as a day-off event alone. The new readers don't see such an absence until the catch-up migration copies it, before the events are dropped (PR 2). Production holds no absences yet, so nothing is affected there today.
Verification
Absencerow is seen by all three readers, and a person with only a day-off event no longer is. It failed before the switch on all three.createDayOffdoes.