Repository navigation
fix(events): keep absences out of the programme list's bulk actions - #568
Merged
Merged
Conversation
Publishing, unpublishing and deleting programmes in bulk took any event id the request posted, so a programme manager could, with a hand-written request, unpublish or delete someone's absence. The list never offers one; the actions now refuse them too, as the single event pages already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while reviewing #566.
The programme list's bulk actions (publish, unpublish, delete) narrow the posted ids through
filterToManageableEventIds. For a programme manager it returned every event of the congregation, absences included. The list never offers an absence, but a hand-written request could unpublish or delete someone else's absence.The filter now reads programmes only, through
PROGRAMME_EVENT, the same rule the single event pages already apply throughfindProgrammeEvent. An absence's id posted to a bulk action is dropped like an id from another congregation.Verification