Skip to content

fix(events): keep absences out of the programme list's bulk actions - #568

Merged
mindsers merged 1 commit into
mainfrom
fix/bulk-actions-skip-absences
Nov 19, 2026
Merged

mindsers merged 1 commit into
mainfrom
fix/bulk-actions-skip-absences

Conversation

@mindsers

Copy link
Copy Markdown
Contributor

Found while reviewing #566.

The programme list's bulk actions (publish, unpublish, delete) narrow the posted ids through filterToManageableEventIds. For a programme manager it returned every event of the congregation, absences included. The list never offers an absence, but a hand-written request could unpublish or delete someone else's absence.

The filter now reads programmes only, through PROGRAMME_EVENT, the same rule the single event pages already apply through findProgrammeEvent. An absence's id posted to a bulk action is dropped like an id from another congregation.

Verification

  • A new integration test posts an absence's id and a programme's id as a programme manager; only the programme goes through. It failed before the fix.
  • Unit (653 files) and integration (121 files) suites, lint, typecheck, boundaries, tenant scoping. References unchanged.

Publishing, unpublishing and deleting programmes in bulk took any event id the request posted, so a programme manager could, with a hand-written request, unpublish or delete someone's absence. The list never offers one; the actions now refuse them too, as the single event pages already do.
@mindsers
mindsers merged commit bf2bc0e into main Nov 19, 2026
7 checks passed
@mindsers
mindsers deleted the fix/bulk-actions-skip-absences branch November 19, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant