Repository navigation
fix(tokens): name the map glyph stacks Unitae Map, not IBM Plex - #10
Merged
Merged
Conversation
The glyphs are IBM Plex Sans turned into map SDF glyphs. The font's licence (OFL 1.1, Reserved Font Name "Plex") keeps that name for unmodified versions, and glyphs are a modified version, so MAP_FONTS now asks for Unitae Map Regular, Medium and Italic. Same letterforms; the host ships the OFL and IBM's copyright with the glyphs. 0.2.0 is not published yet, so the version stays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAP_FONTSasked forIBM Plex Sans Regular / Medium / Italic. The glyphs the app serves are IBM Plex Sans turned into map SDF glyphs, and the font's licence (OFL 1.1, Reserved Font Name "Plex" — in IBM's package and in the Google Fonts copy alike) keeps that name for unmodified versions. Glyphs are a modified version, so they need another name.MAP_FONTS→Unitae Map Regular,Unitae Map Medium,Unitae Map Italic. Same letterforms.@unitae/tokens0.2.0 has not been published yet, so the version stays: tagtokens-v0.2.0after this merges.Test plan
pnpm test:lint,pnpm test:typecheck, tokens tests (108)