Add PIR remediation verification gates#1454
Open
jddark62 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
post-incident-reviewSkill path:
skills/incident-response/post-incident-review/What Was Wrong
Fixes #1398.
The skill produced a remediation plan with owners, priorities, deadlines, and tickets, but it did not require proof that a remediation actually worked before closure. This can create a false positive PIR outcome where a closed ticket is treated as root-cause remediation even when no retest, detection validation, control evidence, recurrence monitoring, or overdue escalation exists.
What This PR Fixes
Implemented-Unverified,Verified,Monitoring,Overdue, andRisk Acceptedstates.Evidence
Before (false positive PIR outcome):
The old template could treat this as completed remediation because the ticket was closed.
After (now correctly handled):
The remediation plan requires acceptance criteria and evidence before closure, and the PIR output distinguishes
Implemented-UnverifiedfromVerified. Detective changes require test events, alert routing, and owner confirmation; recurrence monitoring and overdue risk treatment are explicit.Test Cases Added/Updated
tests/vulnerable/)tests/benign/)Validation performed:
python3content sanity check for version, verification gate, closure states, verification report fields, and new pitfallsgit diff --checkBounty Tier
Bounty Info
Bounty Info
/claim #1398