-
Notifications
You must be signed in to change notification settings - Fork 111
docs: add PCI scope change evidence gates #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
catcherintheroad-hub
wants to merge
1
commit into
UnitOneAI:main
Choose a base branch
from
catcherintheroad-hub:improve/pci-scope-change-evidence
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
skills/compliance/pci-dss-review/tests/scope-change-edge-cases.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| # PCI Scope Change Edge Cases | ||
|
|
||
| These fixtures validate PCI DSS v4.0 review behavior for significant-change scope impact analysis under Req 12.5.3. | ||
|
|
||
| ## Case 1: New Serverless Payment Flow After Annual Review | ||
|
|
||
| ```yaml | ||
| annual_scope_review: | ||
| completed: "2026-01-15" | ||
| change: | ||
| id: CHG-101 | ||
| deployed: "2026-04-10" | ||
| component: payment-webhook-lambda | ||
| handles: | ||
| - payment_token | ||
| - transaction_metadata | ||
| pci_scope_impact_review: missing | ||
| cde_diagram_updated: false | ||
| ``` | ||
|
|
||
| **Expected result:** High severity finding. | ||
|
|
||
| **Reason:** A new payment flow was deployed after annual scope confirmation without change-specific PCI scope impact evidence. | ||
|
|
||
| ## Case 2: Segmentation Change Without Revalidation | ||
|
|
||
| ```yaml | ||
| change: | ||
| id: CHG-202 | ||
| type: firewall_rule_update | ||
| affects: | ||
| - cde_to_corp_network | ||
| - admin_vpn_to_cde | ||
| segmentation_validation: | ||
| updated_pen_test: false | ||
| route_review: partial | ||
| security_owner_approval: true | ||
| ``` | ||
|
|
||
| **Expected result:** High severity finding. | ||
|
|
||
| **Reason:** Segmentation-affecting changes require refreshed validation evidence; approval alone does not prove segmentation remains effective. | ||
|
|
||
| ## Case 3: TPSP Responsibility Changed | ||
|
|
||
| ```yaml | ||
| provider_change: | ||
| id: CHG-303 | ||
| provider: fraud-analytics-saas | ||
| new_data_access: | ||
| - transaction_id | ||
| - masked_pan | ||
| tpsp_inventory_updated: false | ||
| responsibility_matrix_updated: false | ||
| aoc_reviewed: false | ||
| ``` | ||
|
|
||
| **Expected result:** High severity finding. | ||
|
|
||
| **Reason:** Provider responsibility and data access changed, but the TPSP inventory, responsibility matrix, and compliance evidence were not refreshed. | ||
|
|
||
| ## Case 4: Complete Scope Impact Evidence | ||
|
|
||
| ```yaml | ||
| scope_change_impact: | ||
| change_id: CHG-404 | ||
| trigger: new_payment_api | ||
| owner: pci-program-manager | ||
| reviewed_before_release: true | ||
| data_flow_update: | ||
| chd_sad_flow_changed: true | ||
| diagram_version: cde-flow-v18 | ||
| scope_inventory: | ||
| cde_components_added: | ||
| - payment-api | ||
| connected_to_systems_added: | ||
| - auth-service | ||
| - siem-forwarder | ||
| segmentation: | ||
| affected: true | ||
| validation_evidence: seg-test-2026-06-01 | ||
| tpsp: | ||
| affected: true | ||
| responsibility_matrix_version: tpsp-raci-v9 | ||
| aoc_status_reviewed: true | ||
| evidence_refresh: | ||
| requirements: | ||
| - "1" | ||
| - "6" | ||
| - "10" | ||
| - "11" | ||
| - "12" | ||
| approvals: | ||
| security_owner: approved | ||
| business_owner: approved | ||
| pci_owner: approved | ||
| ``` | ||
|
|
||
| **Expected result:** Pass for Req 12.5.3 evidence if implementation evidence matches the record. | ||
|
|
||
| **Reason:** The change is explicitly tied to scope, data-flow, segmentation, TPSP, evidence refresh, and owner approval artifacts. | ||
|
|
||
| ## Review Assertions | ||
|
|
||
| - Do not accept annual scope confirmation as proof of mid-cycle change review. | ||
| - Confirm payment, network, cloud, TPSP, and security-impacting changes trigger PCI scope impact analysis. | ||
| - Confirm segmentation changes refresh validation evidence. | ||
| - Confirm scope reduction claims are updated after architecture changes. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new gate applies Req 12.5.3 to every significant technical/environment change, but PCI DSS v4.0 12.5.3 is an additional requirement for service providers covering significant organizational-structure changes and communication of the documented scope/control impact review to executive management. For merchants or changes like serverless payment flows, firewall rules, or cloud architecture, this will make the skill cite the wrong requirement and produce false high-severity 12.5.3 findings instead of using 12.5.2 and the applicable testing requirements.
Useful? React with 👍 / 👎.