-
Notifications
You must be signed in to change notification settings - Fork 107
docs: add alert triage suppression gates #1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
catcherintheroad-hub
wants to merge
1
commit into
UnitOneAI:main
Choose a base branch
from
catcherintheroad-hub:improve/alert-triage-dedup-evidence
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
skills/secops/alert-triage/tests/dedup-suppression-edge-cases.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| # Alert Triage De-duplication and Suppression Edge Cases | ||
|
|
||
| These fixtures validate that alert-triage does not collapse alert storms or | ||
| recommend permanent suppressions without ownership, scope, and correlation | ||
| evidence. | ||
|
|
||
| ## Edge Case 1: Same Raw Event, Multiple Tool Notifications | ||
|
|
||
| Input evidence: | ||
|
|
||
| ```yaml | ||
| alerts: | ||
| - alert_id: siem-1001 | ||
| rule: suspicious_powershell | ||
| raw_event_id: win-4688-abc | ||
| host: ws-17 | ||
| user: alice | ||
| - alert_id: edr-9911 | ||
| rule: suspicious_powershell | ||
| raw_event_id: win-4688-abc | ||
| host: ws-17 | ||
| user: alice | ||
| ``` | ||
|
|
||
| Expected output: | ||
|
|
||
| - Finding ID: `TRIAGE-DEDUP-01` | ||
| - Alerts may be de-duplicated in the case record | ||
| - Evidence retains one raw event reference and both alert IDs | ||
| - Priority is based on behavior and context, not duplicate count alone | ||
|
|
||
| ## Edge Case 2: Password Spray Mistaken for Duplicate Noise | ||
|
|
||
| Input evidence: | ||
|
|
||
| ```yaml | ||
| rule: failed_login_threshold | ||
| time_window_utc: "2026-06-06T08:00:00Z/2026-06-06T08:10:00Z" | ||
| distinct_users: 184 | ||
| distinct_hosts: 1 | ||
| source_ip: 203.0.113.50 | ||
| prior_disposition: "false_positive" | ||
| prior_disposition_date: "2025-12-01" | ||
| ``` | ||
|
|
||
| Expected output: | ||
|
|
||
| - Finding ID: `TRIAGE-DEDUP-02` or `TRIAGE-DEDUP-04` | ||
| - Do not reuse stale prior disposition | ||
| - Treat as possible password spraying until benign cause is proven | ||
| - Correlation checks include source IP reputation and successful logons after failures | ||
|
|
||
| ## Edge Case 3: Broad Suppression Request for Admin Activity | ||
|
|
||
| Input evidence: | ||
|
|
||
| ```yaml | ||
| disposition: BTP | ||
| activity: authorized_admin_script | ||
| affected_assets: | ||
| - domain_controller | ||
| - production_database | ||
| proposed_suppression: | ||
| filter: "user_role = admin" | ||
| owner: null | ||
| expiry: null | ||
| rollback: null | ||
| ticket: null | ||
| ``` | ||
|
|
||
| Expected output: | ||
|
|
||
| - Finding ID: `TRIAGE-SUP-01` and `TRIAGE-SUP-02` | ||
| - Suppression is rejected or narrowed | ||
| - Required evidence includes change ticket, owner, expiry, rollback path, and exact host/script scope | ||
| - Escalate to detection owner before any filter affecting privileged users or critical assets |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the same raw event produces multiple tool notifications, this guidance only requires retaining one evidence reference. In that duplicate-notification scenario, the triage record still needs every alert ID so each SIEM/EDR notification can be closed or linked; otherwise an analyst following the template may document the raw event once but lose the secondary alert IDs from the case record.
Useful? React with 👍 / 👎.