-
Notifications
You must be signed in to change notification settings - Fork 108
docs: add log timeline evidence gates #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
catcherintheroad-hub
wants to merge
1
commit into
UnitOneAI:main
Choose a base branch
from
catcherintheroad-hub:improve/log-analysis-timeline-evidence
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
skills/secops/log-analysis/tests/timeline-evidence-edge-cases.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| # Log Analysis Timeline Evidence Edge Cases | ||
|
|
||
| These fixtures validate that log-analysis reports preserve timeline integrity | ||
| and avoid overconfident conclusions when timestamps, pipeline health, or raw | ||
| evidence are incomplete. | ||
|
|
||
| ## Edge Case 1: Mixed Local Time and UTC | ||
|
|
||
| Input evidence: | ||
|
|
||
| ```json | ||
| [ | ||
| { | ||
| "source": "windows_security", | ||
| "event_id": 4624, | ||
| "event_time": "2026-06-06 01:58:03", | ||
| "timezone": "America/Los_Angeles", | ||
| "host": "ws-17", | ||
| "user": "alice" | ||
| }, | ||
| { | ||
| "source": "azure_ad_signin", | ||
| "event_time": "2026-06-06T09:59:10Z", | ||
| "ingestion_time": "2026-06-06T10:04:33Z", | ||
| "user": "alice" | ||
| } | ||
| ] | ||
| ``` | ||
|
|
||
| Expected output: | ||
|
|
||
| - Finding ID: `LOG-TIME-01` if timezone is missing for any source | ||
| - Timeline shows UTC-normalized timestamps and retains original timestamps | ||
| - Do not assert exact sequence ordering unless clock-skew tolerance is documented | ||
|
|
||
| ## Edge Case 2: Log Pipeline Gap During Incident Window | ||
|
|
||
| Input evidence: | ||
|
|
||
| ```yaml | ||
| incident_window_utc: "2026-06-06T02:00:00Z/2026-06-06T03:00:00Z" | ||
| pipeline_health: | ||
| source: edr_telemetry | ||
| dropped_events: 12943 | ||
| outage_window_utc: "2026-06-06T02:15:00Z/2026-06-06T02:41:00Z" | ||
| finding_claim: "No process execution occurred after suspicious logon" | ||
| ``` | ||
|
|
||
| Expected output: | ||
|
|
||
| - Finding ID: `LOG-TIME-04` | ||
| - Visibility Gaps records the EDR outage | ||
| - Report avoids definitive negative claims about missing process execution | ||
| - Recommendations include pipeline recovery and alternate-source review | ||
|
|
||
| ## Edge Case 3: Normalized Fields Without Raw Event Spot Check | ||
|
|
||
| Input evidence: | ||
|
|
||
| ```yaml | ||
| siem_result: | ||
| query_id: q-8842 | ||
| parser_version: auth_parser_v9 | ||
| normalized_fields: | ||
| action: login_success | ||
| src_ip: 203.0.113.50 | ||
| user: svc-build | ||
| timestamp_utc: "2026-06-06T04:12:00Z" | ||
| raw_export: | ||
| path: null | ||
| sha256: null | ||
| ``` | ||
|
|
||
| Expected output: | ||
|
|
||
| - Finding ID: `LOG-EVID-01`, `LOG-EVID-03`, or `LOG-EVID-05` | ||
| - Confidence is reduced because no raw-event spot check is available | ||
| - Evidence Handling records missing export path and hash | ||
| - Remediation requests raw export preservation and query text retention | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixture has no raw export path, no hash, and only normalized SIEM fields, so it simultaneously satisfies
LOG-EVID-01,LOG-EVID-03, andLOG-EVID-05as defined in the new skill checks. Usingorlets a report pass while ignoring two of the missing-evidence conditions, which weakens the edge-case coverage for the evidence gates this test is meant to validate.Useful? React with 👍 / 👎.