Add HTTP parser boundary review gates#1281
Open
bozicovichsantiago20-oss wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
secure-code-reviewSkill path:
skills/appsec/secure-code-review/What Was Wrong
The skill covered common injection, auth, file, SSRF, and deserialization review paths, but it did not give reviewers a concrete gate for HTTP request smuggling / parser-boundary issues. That left two failure modes from #1174 uncovered:
Addresses #1174.
What This PR Fixes
secure-code-reviewto v1.0.1.Boundary Evidenceto finding output and CWE-444 supplemental coverage.Evidence
Before (skill misses this / false positive on this):
The first pattern needs parser-boundary review; the second should not be reported as CWE-444 by itself.
After (now correctly handled):
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)Inline vulnerable and benign examples were added in the skill file. This skill currently has no
tests/directory, so validation was performed against the Markdown skill content and references.Bounty Tier
Bounty Info
Validation
git diff --checkCWE-444,Boundary Evidence,Content-Length,Transfer-Encoding,HTTP/2-to-HTTP/1,raw-bodySECURITY.md: OKTested with: Codex GPT-5