Add PCI payment-page script evidence gates#1273
Open
alejandrorivas-pixel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
pci-dss-reviewSkill path:
skills/compliance/pci-dss-review/Closes #1272.
What Was Wrong
The skill listed PCI DSS Requirements 6.4.3 and 11.6.1, but did not make payment-page script management and browser-side tamper detection assessor-verifiable. That created two problems:
What This PR Fixes
This PR adds a dedicated payment-page evidence workflow for PCI DSS v4.0.1 review:
Evidence
Before (skill misses this / false positive on this):
A reviewer could see this on a payment page and only know that Requirement 6.4.3 exists, without structured checks for script owner, written justification, authorization, and integrity evidence.
After (now correctly handled):
The skill now requires payment-page URL inventory, browser-observed script inventory, written justification, authorization method, integrity assurance, and TPSP/3DS responsibility evidence before marking the requirement in place.
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)New fixtures:
skills/compliance/pci-dss-review/tests/vulnerable/payment-page-scripts-no-inventory.htmlskills/compliance/pci-dss-review/tests/vulnerable/server-fim-only-payment-page-monitoring.mdskills/compliance/pci-dss-review/tests/benign/provider-owned-3ds-iframe-evidence.htmlskills/compliance/pci-dss-review/tests/benign/browser-tamper-monitoring-evidence.mdValidation
git diff --checkgit diff --cached --checkskills/compliance/pci-dss-review/SKILL.mdcurlfor PCI SSC Document Library, PCI DSS v4.0.1 publication, FAQ 1581, and PCI SSC e-commerce guidance blogBounty Tier
Bounty Info