fix: correct deprecated function reference in action dispatch comments#559
Open
BhariGowda wants to merge 1 commit into
Open
fix: correct deprecated function reference in action dispatch comments#559BhariGowda wants to merge 1 commit into
BhariGowda wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
PositionManager.sol, the action dispatch comments forINCREASE_LIQUIDITY_FROM_DELTASandMINT_POSITION_FROM_DELTASincorrectly reference the deprecated functions themselves as the "see also" guidance, rather than pointing developers to the safe replacements.Changes
Line 203 (before):
// DEPRECATED - vulnerable to sandwich attacks, do not use. See _increaseFromDeltas().Line 203 (after):
// DEPRECATED - vulnerable to sandwich attacks, do not use. See _increase() instead.Line 227 (before):
// DEPRECATED - vulnerable to sandwich attacks, do not use. See _mintFromDeltas().Line 227 (after):
// DEPRECATED - vulnerable to sandwich attacks, do not use. See _mint() instead.The function-level NatSpec at lines 308 and 392 already correctly references
_increase()and_mint()— this PR aligns the action dispatch comments to match.