fix: Fix typo in test file and expose poolKeys in IPositionManager in…#509
fix: Fix typo in test file and expose poolKeys in IPositionManager in…#509Trustdev-eth wants to merge 2 commits into
Conversation
|
The bytes25 poolId used here is NOT compatible with the PoolId type /// @dev This poolId is NOT compatible with the PoolId type from v4-core. |
…ot v4-core PoolId
Good call — added @dev NatSpec on poolKeys in IPositionManager that this is truncated bytes25 from PositionInfo, not v4-core PoolId (bytes32), aligned with PositionInfoLibrary. |
Related Issue
Fixes #[issue-number-1] - Typo in the name of test file
Fixes #[issue-number-2] - IPositionManager doesn't expose
poolKeys(bytes32)Description of changes
This PR fixes two bugs:
Fixed typo in test file name: Renamed
DeployPoolMofifyLiquidityTest.t.soltoDeployPoolModifyLiquidityTest.t.sol(corrected "Mofify" → "Modify")Exposed
poolKeysfunction in IPositionManager interface: Added the missingpoolKeys(bytes25 poolId)function declaration to theIPositionManagerinterface. ThePositionManagercontract already has a public mappingpoolKeys, but it wasn't exposed in the interface, making it inaccessible through the interface.Changes Made
test/script/DeployPoolMofifyLiquidityTest.t.sol→test/script/DeployPoolModifyLiquidityTest.t.solfunction poolKeys(bytes25 poolId) external view returns (PoolKey memory);tosrc/interfaces/IPositionManager.solTesting
forge test)Checklist