Adds robinhood fee activation & v4 fee activation#148
Open
jtriley2p wants to merge 57 commits into
Open
Conversation
Closed
jtriley2p
marked this pull request as ready for review
July 15, 2026 01:57
…protocol-fees into jtriley2p/v4-fees-and-robinhood
hensha256
reviewed
Jul 17, 2026
hensha256
reviewed
Jul 17, 2026
hensha256
reviewed
Jul 17, 2026
hensha256
reviewed
Jul 17, 2026
…ccount (XDM), not OptimismPortal2 WorldChain and XLayer v4 PoolManagers are owned by their CrossChainAccount, not the aliased Timelock -- verified onchain: PoolManager.owner() == crossChainAccount, and crossChainAccount.l1Owner == mainnet Timelock via the L2CrossDomainMessenger. Activating via OptimismPortal2Encoder delivers setProtocolFeeController from the aliased Timelock, so the L1 proposal executes but the L2 call reverts on onlyOwner -- v4 fees never activate on these two chains, and the OP deposit (unlike an Arbitrum retryable) cannot be retried without a new governance vote. Switch both to L1CrossDomainMessengerEncoder -> CrossChainAccount.forward, matching the other five OP-stack chains (Base/Celo/Optimism/Soneium/Zora). Remove the now-unused OptimismPortal2Encoder and IL1CrossDomainMessenger imports. Verified owner-vs-encoder-sender onchain for all reachable target chains; only WorldChain and XLayer were mismatched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add the LBPStrategy hook (0x095e38a2135aeBcfFa98A5B6911591937f912000, verified deployed on Robinhood) to the Robinhood hook-family assignments so its pools are classified into the native-math family (255), like the other Robinhood LBP/CCA hooks. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
zhongeric
previously approved these changes
Jul 17, 2026
…ion-encoder fix(proposal-6): WorldChain & XLayer v4 activation must use CrossChainAccount (XDM), not OptimismPortal2
hensha256
reviewed
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.