IEM ASOS Data#254
Conversation
…or IemAsos Class.
WEP11
requested review from
dopplershift,
jrleeman and
lesserwhirls
as code owners
jrleeman
left a comment
jrleeman
left a comment
There was a problem hiding this comment.
Maybe this class lives in iastate.py? Would using HTTPEndpoint make things easier?
| # Strip whitespace from the column names | ||
| df.columns = df.columns.str.strip() | ||
|
|
||
| df['valid'] = pd.to_datetime(df['valid'], format="%Y-%m-%d %H:%M:%S") |
There was a problem hiding this comment.
Would you mind adding df.units = a dict of the units if possible here so it would work with our unit helper like we do with upper air data?
There was a problem hiding this comment.
I'll take care of it!
| from ..http_util import create_http_session | ||
|
|
||
|
|
||
| class IemAsos: |
There was a problem hiding this comment.
Hmmm. IEMAsos, 'IEMasos, IAStateASOS, IAStateasos? Not sure on fighting convention for readability. Thoughts @dopplershift ?
|
Hi @WEP11, I've made some promises to do work on siphon + IEM web services and so I am reviewing things. Do you have interest in furthering this PR or can I "take it from here" ? :) |
@akrherz Go for it! I completely forgot about this, I must have had a busy 2018/2019. I deeply apologize for forgetting about this. But you're the IEM expert, so perhaps it's a blessing in disguise! |
3 participants
This PR addresses #157 , adding the ability to download IEM ASOS data.
The IemAsos class will:
The DataFrame object is then accessible to the user through the data attribute, with column headers from IEM being retained for use by the DataFrame.
Still needed: