#003 adding qdlmove#7
Merged
Merged
Conversation
…-Lab/QDL-utils into feature-addple
…s now constructed at the start of each new scan.
…s in preparation for scanner/scope fix
…RateCounter classes which broke scan/scope. Initial PLE implementation complete.
…re and clean up code.
…efocusing on enter key and renamed nidaqpiezo for general use.
Adding PLE scanner application
…re and clean up code.
…efocusing on enter key and renamed nidaqpiezo for general use.
…fect-Lab/qdl-utils into 003-adding-qdlmove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is in response to issue #3 and implements the base version of
qdlmovewhich is an application for moving the micrometers and piezos via direct input (e.g. by setting the value directly) and by stepping a specified distance via the keyboard arrow keys (for x and y) or the '-' and '+' keys (for z).The code is setup with indicated areas to be modified for additional hardware including other types of positioners. Currently two new controllers were added:
newportmicrometer.py(for Newport mechanized micrometers via serial port connection) andnidaqpiezo.py(which implements a simplified version of thenipizeojenapyrepo for controlling the position of piezos actuated by analog voltage output of an NIDAQ board). The latter controller will be used as a base for simplified piezo scanning as relating to issue #5.After configuring the
qdlmove_micros_and_piezos.yamlfile located inqdlmove.config_filesto match your specific system, the code is currently configured to handle a single micrometer (xy) and single piezo (xyz), but can be modified for additional hardware as needed. Users can input specific positions and drive the hardware to those positions by GUI, or enable stepping via a GUI element to move the position via the arrow and +/- keys.NOTE: This branch was based off of the feature-clean-ple branch which is currently being prepared for merging into main in Pull Request #1, which should be merged before this one is finalized. This branch should merge the changes from main (after #1 is resolved) before being merged in. All changes specific to this change are located in the
qdlmovefolder.