fix(webpack): fix dev server unable to compile#131
Open
PixnBits wants to merge 3 commits into
Open
Conversation
node built-in modules not needed for d3-request dependency
Contributor
Author
|
On the upside Travis is building PRs and webpack was able to build, but it looks like the saucelabs connectivity is broken going to try out adding a change from karma-runner/karma-sauce-launcher#73 to this PR, which is a bit of scope creep but given this is the first PR in a while maybe the scope is less webpack and more PR builds \m/ |
Contributor
Author
Connecting, so that's progress. Going to also add username+password from env vars. Not sure if they're configured, so 🤞 |
Contributor
Author
|
Rats, looks like that was fruitless anyway as |
Member
|
Hey friend! Thanks for the PRs! I apologize for not following up: you caught me on vacation. I’m back tomorrow though and can review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node built-in modules not needed for d3-request dependency
admittedly I'm unable to run the tests yet as I'm unsure how to configure a chrome launcher on my pixelbook, hoping Travis is still building these