Skip to content

modifications for updated pandas/numpy packages#458

Merged
catherinebirney merged 45 commits into
developfrom
colab
Nov 7, 2025
Merged

modifications for updated pandas/numpy packages#458
catherinebirney merged 45 commits into
developfrom
colab

Conversation

@catherinebirney

@catherinebirney catherinebirney commented Oct 28, 2025

Copy link
Copy Markdown
Contributor
  • Code modifications required due to updating package requirements to to pandas 2.2+ and numpy 2.0+
  • The changes to this code in this PR do not impact the results of FBA or FBS methods.
  • Drop support for python 3.9, add support for 3.12
  • Test github actions using python 3.12, updated from 3.10

…bfill is deprecated and will change in a future version"
…uld be run - update due to pandas version update
…ndas - .apply() resets flowamount col type within class, resetting np.nan to 0
….dtypes.StrDType'> could not be promoted by <class 'numpy.dtypes._PyFloatDType'>
@catherinebirney catherinebirney changed the title updates for pandas package modifications for updated pandas/numpy packages Oct 29, 2025
@catherinebirney catherinebirney marked this pull request as ready for review October 29, 2025 03:09
@bl-young

Copy link
Copy Markdown
Contributor

Reviewing the FBS diff files:

  • Looks like some diffs are showing up due to differences in how NaN's are handled:
image A minor issue that just makes the diff files longer than needed.
  • Also flagging that StEWI based datasets are showing differences likely due to a more recent Facility matcher dataset being available on the Commons (v1.2.1), so despite the stewicombo data being static, how those facilities are assigned to sectors may have shifted some. In the future we may want to consider if allowing this shift is ok, or if we need to allow fixing the FRS file as well.

Comment thread setup.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to numpy we need to bump this to >= 3.10, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, addressed, thanks!

@WesIngwersen

Copy link
Copy Markdown

I ran Employment_national_2022 successfully without any WARNINGs but was not able to compare it to a previously generated dataset

@catherinebirney

Copy link
Copy Markdown
Contributor Author

I ran Employment_national_2022 successfully without any WARNINGs but was not able to compare it to a previously generated dataset

@WesIngwersen Your inability to compare FBS might have something to do with Ben's comment above about how handling nan has changed. I'm going to look into it this afternoon.

@catherinebirney catherinebirney merged commit db3f608 into develop Nov 7, 2025
10 checks passed
@catherinebirney catherinebirney deleted the colab branch November 7, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants