Feature/dam profile chart#253
Conversation
There was a problem hiding this comment.
Made some suggestion fixes for you from our previous voice conversation.
Open to discussing A2W naming, we could also attribute the graphic to A2W on the page and/or mention that was the source of it? I'm just suggesting we don't name components with it if it does not pull data from that source. (I think I got them all?)
Also wondering if we should go ahead and make a "Graphics" menu / dropdown for link navigation?
| import InteractiveFormTest from "../pages/docs/forms/interactive-test"; | ||
| import { docsConfig } from "../config/docs.config"; | ||
| import GetPrecisionPage from "../pages/docs/utilities/get-precision"; | ||
| import A2wDamProfileDocs from "../pages/docs/plots/a2w-dam-profile"; |
There was a problem hiding this comment.
Suggest we remove A2w naming from all methods.
These do not pull data from A2W and can otherwise be generic.
Just go with DamProfileDocs and dam-profile
| import A2wDamProfileDocs from "../pages/docs/plots/a2w-dam-profile"; | |
| import DamProfileDocs from "../pages/docs/plots/dam-profile"; |
| "/docs/hooks/use-cda-blobs": useCdaBlobs, | ||
| "/docs/plots": PlotsDocs, | ||
| "/docs/plots/cwms-plot": CWMSPlotDocs, | ||
| "/docs/plots/a2w-dam-profile": A2wDamProfileDocs, |
There was a problem hiding this comment.
| "/docs/plots/a2w-dam-profile": A2wDamProfileDocs, | |
| "/docs/plots/dam-profile": DamProfileDocs, |
|
|
||
| function A2wDamProfileDocs() { | ||
| return ( | ||
| <DocsPage middleText="A2W Dam Profile"> |
There was a problem hiding this comment.
| <DocsPage middleText="A2W Dam Profile"> | |
| <DocsPage middleText="Dam Profile"> |
| import PropsTable from "../../components/props-table.jsx"; | ||
| import chartProps from "../../../props-declarations/chart.jsx"; | ||
|
|
||
| function A2wDamProfileDocs() { |
There was a problem hiding this comment.
| function A2wDamProfileDocs() { | |
| function DamProfileDocs() { |
| function A2wDamProfileDocs() { | ||
| return ( | ||
| <DocsPage middleText="A2W Dam Profile"> | ||
| <UsaceBox title="A2W Dam Profile"> |
There was a problem hiding this comment.
| <UsaceBox title="A2W Dam Profile"> | |
| <UsaceBox title="Dam Profile"> |
|
|
||
| <A2WDamProfile | ||
| info={{ | ||
| dambottom: 820, |
There was a problem hiding this comment.
| dambottom: 820, | |
| damBottom: 820, |
| <A2WDamProfile | ||
| info={{ | ||
| dambottom: 820, | ||
| damtop: 913, |
There was a problem hiding this comment.
| damtop: 913, | |
| damTop: 913, |
| updateToast, | ||
| formatSubmissionMessage, | ||
| showDetailedError, | ||
| A2WDamProfile, |
There was a problem hiding this comment.
| A2WDamProfile, | |
| DamProfile, |
| href: `${BASE_URL}#/docs/plots/cwms-plot`, | ||
| }, | ||
| { | ||
| id: "a2w-dam-profile", |
There was a problem hiding this comment.
| id: "a2w-dam-profile", | |
| id: "dam-profile", |
| href: `${BASE_URL}#/docs/plots/cwms-plot`, | ||
| }, | ||
| { | ||
| id: "a2w-dam-profile", |
There was a problem hiding this comment.
Should we make a dropdown for "Graphics"? This appears to be a top level link. If you agree please go ahead!
Graphics > Dam Profile
Eventually
Graphics > Basin Pie
Etc
These would be graphics rendered with d3 ideally
2 participants
No description provided.