feat(autofix): Fix deprecated Configuration APIs#699
Merged
Conversation
RandomByte
force-pushed
the
autofix-basic-configuration-apis-rebased
branch
from
June 13, 2025 12:19
387c180 to
380a937
Compare
maxreichmann
force-pushed
the
autofix-basic-configuration-apis-rebased
branch
from
June 16, 2025 14:43
afe10d5 to
e719759
Compare
RandomByte
commented
Jun 17, 2025
maxreichmann
force-pushed
the
autofix-basic-configuration-apis-rebased
branch
2 times, most recently
from
June 17, 2025 12:27
829e96a to
3c2f75b
Compare
maxreichmann
changed the title
maxreichmann
force-pushed
the
autofix-basic-configuration-apis-rebased
branch
2 times, most recently
from
June 21, 2025 13:04
b36d877 to
f1a0571
Compare
maxreichmann
marked this pull request as ready for review
June 21, 2025 13:17
RandomByte
commented
Jun 23, 2025
RandomByte
left a comment
RandomByte
left a comment
Member
Author
There was a problem hiding this comment.
Just one nitpick, otherwise looking great!
|
|
maxreichmann
force-pushed
the
autofix-basic-configuration-apis-rebased
branch
from
June 24, 2025 09:06
e61bb24 to
18a9939
Compare
Member
Author
|
LGTM |
codeworrior
previously approved these changes
Jun 24, 2025
codeworrior
left a comment
codeworrior
left a comment
Member
There was a problem hiding this comment.
LGTM.
My two comments should not prevent a submit.
| // migration is currently not possible if the return value is used | ||
| // This could be optimized with an advanced migration that detects how the return | ||
| // value is used and e.g. migrates to something like | ||
| // (getAnimationMode() !== sap.ui.core.Configuration.AnimationMode.none) |
Member
There was a problem hiding this comment.
Why can't this be replaced like this in general?
Member
Author
There was a problem hiding this comment.
This comment proposes that
if (Configuration.getAnimation())becomes
if ((Configuration.getAnimationMode() !== sap.ui.core.Configuration.AnimationMode.none))Now you're proposing that any usage of Configuration.getAnimation() could safely be replaced with (Configuration.getAnimationMode() !== sap.ui.core.Configuration.AnimationMode.none), right?
I guess that's correct!
Member
There was a problem hiding this comment.
Yes, that was my proposal. But meanwhile I noticed that the code in sap/Ui/core/Configuration is slightly more complex (it checks the opposite, that none of the false values are set - depends on the evolution of the enum whether this remains equivalent).
Member
There was a problem hiding this comment.
Resolved due being too unsafe to migrate?
Member
Author
|
LGTM |
maxreichmann
force-pushed
the
autofix-basic-configuration-apis-rebased
branch
from
June 26, 2025 08:15
8eca40c to
a21e9d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #683 and #685
JIRA: CPOUI5FOUNDATION-1038